Re: [MXS MMC 2/5] Some cleanups for the MMC driver

Shawn Guo
2011-12-07T11:48:41Z

I'm fine with this cosmetic patch with the comments below addressed.

On Tue, Dec 06, 2011 at 02:41:27PM +0100, Lothar Waßmann wrote:
> - Remove bogus parens around numerical arguments in #define's
> - When defining bit masks, use the #def for the shift count
> instead of repeating the numbers

This change brings a few 'line over 80 characters' checkpatch warnings.

> - Remove bogus whitespace in indentation
> - Remove 'break' at end of switch statement
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> drivers/mmc/host/mxs-mmc.c | 57 +++++++++++++++++++++----------------------
> 1 files changed, 28 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
[...]
> @@ -277,7 +277,7 @@ static irqreturn_t mxs_mmc_irq_handler(int irq, void *dev_id)
>
> stat = readl(host->base + HW_SSP_CTRL1);
> writel(stat & MXS_MMC_IRQ_BITS,
> - host->base + HW_SSP_CTRL1 + MXS_CLR_ADDR);

This is an intended indentation with 7 spaces.

Regards,
Shawn

> + host->base + HW_SSP_CTRL1 + MXS_CLR_ADDR);