From: Wolfram Sang <w.sang@pengutronix.de>
To: r66093@freescale.com
Cc: linux-mmc@vger.kernel.org,
Jerry Huang <Chang-Ming.Huang@freescale.com>,
Gao Guanhua <B22826@freescale.com>
Subject: Re: [PATCH 1/6] ESDHC: add PIO mode support
Date: Wed, 14 Dec 2011 08:04:11 +0100 [thread overview]
Message-ID: <20111214070411.GA2593@pengutronix.de> (raw)
In-Reply-To: <1323829182-1551-2-git-send-email-r66093@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On Wed, Dec 14, 2011 at 10:19:37AM +0800, r66093@freescale.com wrote:
> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
>
> For some FSL ESDHC controller(e.g. P2020E, Rev1.0), the SDHC can not work on
> DMA mode because of the hardware bug, so we set a broken dma flag and use
> PIO mode.
>
> Signed-off-by: Gao Guanhua <B22826@freescale.com>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
NACK for the series
1) If you introduce a new property you always have to document the binding
which is missing. But you don't need to write it because...
2) ... the aproach seems wrong to me. The quirks should be set depending
on the compatible entry, e.g. if compatible == "this_controller" then
quirks |= whatever_needed. Or?
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-12-14 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 2:19 [PATCH 0/6] workaround for FSL's eSDHC controller r66093
2011-12-14 2:19 ` [PATCH 1/6] ESDHC: add PIO mode support r66093
2011-12-14 2:19 ` [PATCH 2/6] SDHCI: AHB2MAG IRQ bypass hardware workaround r66093
2011-12-14 2:19 ` [PATCH 3/6] ESDHC: set the timeout to the max value r66093
2011-12-14 2:19 ` [PATCH 4/6] ESDHC: Power management for ESDHC r66093
2011-12-14 2:19 ` [PATCH 5/6] ESDHC: Workaround for data crc error on p1010rdb r66093
2011-12-14 2:19 ` [PATCH 6/6] ESDHC: Fix DMA errors in kernel booting on P1010 r66093
2011-12-14 7:04 ` Wolfram Sang [this message]
2011-12-15 2:37 ` [PATCH 1/6] ESDHC: add PIO mode support Huang Changming-R66093
2011-12-15 2:44 ` Wolfram Sang
2011-12-15 2:53 ` Huang Changming-R66093
2011-12-15 3:09 ` Wolfram Sang
2011-12-15 7:24 ` Huang Changming-R66093
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214070411.GA2593@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B22826@freescale.com \
--cc=Chang-Ming.Huang@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox