public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Gao Guanhua-B22826 <B22826@freescale.com>
Subject: Re: [PATCH 1/6] ESDHC: add PIO mode support
Date: Thu, 15 Dec 2011 04:09:50 +0100	[thread overview]
Message-ID: <20111215030950.GB12130@pengutronix.de> (raw)
In-Reply-To: <8A2FC72B45BB5A4C9F801431E06AE48F11646D9B@039-SN1MPN1-006.039d.mgd.msft.net>

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

> For P2020E Rev1.0, the DMA can't work, we need the PIO mode.
> For P2020E, P1010E, MPC8536, we can't use the timeout value calculated by driver, we need the max value.
> For P1010E, the eSDHC controller can't use the max possible frequency(e.g. SDHC 50MHz), so we need one workaround to make the SD work

This is SoC specific, not board specific, so you could check for
"fsl,p2020-esdhc" for example. 1010 and 2020-rev1 would need proper compatibles
as well.

> For eSDHC, after suspending, the power of esdhc controller will shutdown, we need to save the value of some registers before suspending, wich will used to restore the context after resuming.
> For eSDHC, the bit DCR[DMA__AHB2MAG_IRQ_BYPASS] can't be set automatically, so we need to set it manually

If this is true for all revisions (be careful about the imx users), you don't
need properties, but could simply set it.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2011-12-15  3:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14  2:19 [PATCH 0/6] workaround for FSL's eSDHC controller r66093
2011-12-14  2:19 ` [PATCH 1/6] ESDHC: add PIO mode support r66093
2011-12-14  2:19   ` [PATCH 2/6] SDHCI: AHB2MAG IRQ bypass hardware workaround r66093
2011-12-14  2:19     ` [PATCH 3/6] ESDHC: set the timeout to the max value r66093
2011-12-14  2:19       ` [PATCH 4/6] ESDHC: Power management for ESDHC r66093
2011-12-14  2:19         ` [PATCH 5/6] ESDHC: Workaround for data crc error on p1010rdb r66093
2011-12-14  2:19           ` [PATCH 6/6] ESDHC: Fix DMA errors in kernel booting on P1010 r66093
2011-12-14  7:04   ` [PATCH 1/6] ESDHC: add PIO mode support Wolfram Sang
2011-12-15  2:37     ` Huang Changming-R66093
2011-12-15  2:44       ` Wolfram Sang
2011-12-15  2:53         ` Huang Changming-R66093
2011-12-15  3:09           ` Wolfram Sang [this message]
2011-12-15  7:24             ` Huang Changming-R66093

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111215030950.GB12130@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=B22826@freescale.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=r66093@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox