From: Aaron Lu <aaron.lu@amd.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, Philip Rakity <prakity@marvell.com>
Subject: Re: [PATCH 2/2] mmc: sdhci: Deal with failure case in sdhci_suspend_host
Date: Thu, 29 Dec 2011 10:32:16 +0800 [thread overview]
Message-ID: <20111229023215.GA7182@ladygaga> (raw)
In-Reply-To: <4EFB0A44.5070006@intel.com>
On Wed, Dec 28, 2011 at 02:23:32PM +0200, Adrian Hunter wrote:
> > -
> > -err_pci_suspend:
> > - while (--i >= 0)
> > - sdhci_resume_host(chip->slots[i]->host);
> > - return ret;
>
> This doesn't look right. This is about having multiple
> host controllers on the same PCI device. If those
> hosts have been successfully suspended, then they must
> be resumed on error.
>
You are right, I failed to understand the code.
Will send the patch again without touching the pci recover code, thanks.
>
> > }
> >
prev parent reply other threads:[~2011-12-29 2:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 3:11 [PATCH 0/2] mmc: sdhci: Fix for sdhci suspend function Aaron Lu
2011-12-28 3:11 ` [PATCH 1/2] mmc: sdhci: Fix tuning timer incorrect setting when suspending host Aaron Lu
2011-12-28 12:24 ` Adrian Hunter
2011-12-28 3:11 ` [PATCH 2/2] mmc: sdhci: Deal with failure case in sdhci_suspend_host Aaron Lu
2011-12-28 12:23 ` Adrian Hunter
2011-12-29 2:32 ` Aaron Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111229023215.GA7182@ladygaga \
--to=aaron.lu@amd.com \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox