From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Chris Ball <cjb@laptop.org>, Kukjin Kim <kgene.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend
Date: Mon, 2 Jan 2012 11:49:25 +0000 [thread overview]
Message-ID: <20120102114925.GF2899@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F01117F.6000206@samsung.com>
On Mon, Jan 02, 2012 at 11:07:59AM +0900, Jaehoon Chung wrote:
> On 12/30/2011 11:24 AM, Mark Brown wrote:
> > +#include <linux/pm.h>
> I think this include is unnecessary.
I think you are wrong. What makes you say that you think it is not
needed?
> > +#ifdef CONFIG_PM
> > static const struct dev_pm_ops sdhci_s3c_pmops = {
> > - .suspend = sdhci_s3c_suspend,
> > - .resume = sdhci_s3c_resume,
> > + SET_SYSTEM_SLEEP_PM_OPS(sdhci_s3c_suspend, sdhci_s3c_resume)
Note that above.
next prev parent reply other threads:[~2012-01-02 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 2:24 [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend Mark Brown
2011-12-30 2:24 ` [PATCH 2/2] mmc: sdhci-s3c: Enable runtime power management Mark Brown
2012-01-02 2:07 ` [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend Jaehoon Chung
2012-01-02 11:49 ` Mark Brown [this message]
2012-01-02 15:24 ` Jae hoon Chung
2012-01-02 17:32 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-02-15 18:15 Mark Brown
2012-03-03 0:44 [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support Kukjin Kim
2012-03-03 0:46 ` [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend Mark Brown
2012-03-05 10:24 ` Jaehoon Chung
2012-03-09 4:56 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102114925.GF2899@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).