linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@amd.com>
To: Matthieu CASTET <matthieu.castet@parrot.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: sdhci max_blk_size
Date: Thu, 5 Jan 2012 09:16:35 +0800	[thread overview]
Message-ID: <20120105011634.GA32160@ladygaga> (raw)
In-Reply-To: <4F0469B3.9080400@parrot.com>

On Wed, Jan 04, 2012 at 04:01:07PM +0100, Matthieu CASTET wrote:
> Hi,
> 
> our controller set "Max Block Length" to 3 (4096 byte), but the linux driver
> ignore this value [1].
> 
> Is there any reason to do that .

The reason is, sd host controller spec defines 3 as reserved, not 4096.

> Or it is code that was written with an older sdhci spec, and we can ignore this
> check today.

The current sdhci driver follows v3 spec, is the v4 spec out that
defined this bit?

> 
> 
> 
> Matthieu
> 
> PS : please keep me in CC.
> 
> [1]
> if (mmc->max_blk_size >= 3) {
>             pr_warning("%s: Invalid maximum block size, "
>                 "assuming 512 bytes\n", mmc_hostname(mmc));
>             mmc->max_blk_size = 0;
>         }
> --


  reply	other threads:[~2012-01-05  1:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 15:01 sdhci max_blk_size Matthieu CASTET
2012-01-05  1:16 ` Aaron Lu [this message]
2012-01-05 12:46   ` Matthieu CASTET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105011634.GA32160@ladygaga \
    --to=aaron.lu@amd.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matthieu.castet@parrot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).