From: Aaron Lu <aaron.lu@amd.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card
Date: Fri, 13 Jan 2012 14:20:35 +0800 [thread overview]
Message-ID: <20120113062034.GA2701@ladygaga> (raw)
In-Reply-To: <8A2FC72B45BB5A4C9F801431E06AE48F11669487@039-SN1MPN1-005.039d.mgd.msft.net>
On Fri, Jan 13, 2012 at 04:50:11AM +0000, Huang Changming-R66093 wrote:
>
>
> > I think this function has to take care of standard sd host behaviour: if
> > a specific host has implemented the get_cd callback, then use it; if
> > not, then see the BROKEN_DETECT quirk; finally, use the present register
> > to get the value like the sdhci_request function does.
> >
> Yes, I have thought about it.
> In this patch, only FSL eSDHC use it.
Only FSL eSDHC defines it, but all sd hosts will use it since the call
is made in core.c with host->ops->get_cd.
If you only cares about FSL eSDHC, then probably you should do this in
sdhci.c instead of core.c, by adding a callback to the sdhci_ops and in
the sdhci_request call, instead of checking present register, call the
get_cd callback if available.
> For the other platform, the get_cd is NULL.
>
next prev parent reply other threads:[~2012-01-13 6:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 2:18 [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card r66093
2011-12-14 4:51 ` Philip Rakity
2011-12-15 2:32 ` Huang Changming-R66093
2011-12-15 6:41 ` Philip Rakity
2011-12-15 6:56 ` Huang Changming-R66093
2011-12-15 10:04 ` Jaehoon Chung
2011-12-16 3:25 ` Huang Changming-R66093
2011-12-16 4:05 ` Jaehoon Chung
2011-12-16 4:33 ` Huang Changming-R66093
2012-01-13 2:25 ` Huang Changming-R66093
2012-01-13 3:26 ` Aaron Lu
2012-01-13 4:50 ` Huang Changming-R66093
2012-01-13 6:20 ` Aaron Lu [this message]
2012-01-13 6:44 ` Huang Changming-R66093
-- strict thread matches above, loose matches on Subject: below --
2012-10-30 8:12 [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() r66093
2012-10-30 8:12 ` [PATCH 2/4 v4] MMC/SD: Add callback function to detect card r66093
2012-10-30 8:12 ` [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card r66093
2012-11-19 2:50 ` Huang Changming-R66093
2012-11-19 2:58 ` Anton Vorontsov
2012-11-19 3:15 ` Huang Changming-R66093
2012-11-19 3:31 ` Anton Vorontsov
2012-11-19 3:38 ` Huang Changming-R66093
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113062034.GA2701@ladygaga \
--to=aaron.lu@amd.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).