From: Greg KH <gregkh@suse.de>
To: "Németh Márton" <nm127@freemail.hu>
Cc: Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, devel@driverdev.osuosl.org,
techeng <dzshen@gmail.com>,
clyu@citiz.net, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add Winbond WB528SD Secure Digital (SD) card reader driver
Date: Sat, 21 Jan 2012 07:51:53 -0500 [thread overview]
Message-ID: <20120121125153.GB18829@suse.de> (raw)
In-Reply-To: <4F1A98F5.3080402@freemail.hu>
On Sat, Jan 21, 2012 at 11:52:37AM +0100, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> This driver version of Winbond WB528SD can detect mechanical card
> presence only. The information is provided through sysfs.
How is it provided through sysfs? Is this done in a standard way? If
not, why not?
Why is this driver submitted to the staging tree? What is keeping it
from going into the "real" portion of the kernel for other card readers?
We need a TODO file for what is needed to get it moved out of staging.
Oh, and it needs to do a bit more than just detect a card to be useful,
right? How about read/write to it?
thanks,
greg k-h
next prev parent reply other threads:[~2012-01-21 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 10:52 [PATCH] Add Winbond WB528SD Secure Digital (SD) card reader driver Németh Márton
2012-01-21 12:51 ` Greg KH [this message]
2012-01-21 14:54 ` Németh Márton
2012-01-21 15:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121125153.GB18829@suse.de \
--to=gregkh@suse.de \
--cc=cjb@laptop.org \
--cc=clyu@citiz.net \
--cc=devel@driverdev.osuosl.org \
--cc=dzshen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).