public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Ido Yariv <ido@wizery.com>
To: "Rajashekhara, Sudhakar" <sudhakar.raj@ti.com>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Chris Ball <cjb@laptop.org>, "Nori, Sekhar" <nsekhar@ti.com>
Subject: Re: [RFC 1/2] mmc: davinci: Eliminate spurious interrupts
Date: Sun, 29 Jan 2012 21:37:10 +0200	[thread overview]
Message-ID: <20120129193710.GA24514@WorkStation> (raw)
In-Reply-To: <B6A220404B6BFC4BBD2AB91C54D39DF43176A5C7@DBDE01.ent.ti.com>

Hello Sudhakar,

On Fri, Jan 27, 2012 at 08:11:55AM +0000, Rajashekhara, Sudhakar wrote:
> I tested both these patches and they work fine on the OMAP-L138 EVM. I
> observed that with these patches the number of interrupts during a transfer
> are less compared to earlier. For a 100 MB transfer, I could see around
> 700-800 interrupts less. Did you see any performance improvement with these
> patches?

Thanks for testing these.

The difference in the number of interrupts, or rather the ratio, depends
on the scenario you're working on.
The spurious patch has an effect on non-dma transfers, while the polling
optimization affects small (i.e. up to 128 bytes) transactions.
I expect these to have a greater impact on SDIO scenarios than on SD scenarios.

Regarding the performance improvement, these patches were tested using a
WLAN SDIO adapter, which requires quite a few small transactions.
The polling optimization had an impact of around 10-15% in throughput.
The spurious patch did not have any noticeable effect on throughput, but did
lower the number of interrupts by up to 25% in some cases.

Thanks,
Ido.

  reply	other threads:[~2012-01-29 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4F1E9194.90608@mvista.com>
2012-01-24 11:16 ` [RFC 1/2] mmc: davinci: Eliminate spurious interrupts Ido Yariv
2012-01-24 11:16   ` [RFC 2/2] mmc: davinci: Poll status for small size transfers Ido Yariv
2012-01-27  8:11   ` [RFC 1/2] mmc: davinci: Eliminate spurious interrupts Rajashekhara, Sudhakar
2012-01-29 19:37     ` Ido Yariv [this message]
     [not found]   ` <1327403766-962-1-git-send-email-ido-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2012-01-31 11:30     ` Rajashekhara, Sudhakar
2012-03-11 21:39       ` [PATCH REPOST " Ido Yariv
2012-03-11 21:39         ` [PATCH REPOST 2/2] mmc: davinci: Poll status for small size transfers Ido Yariv
2012-03-16  3:32         ` [PATCH REPOST 1/2] mmc: davinci: Eliminate spurious interrupts Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120129193710.GA24514@WorkStation \
    --to=ido@wizery.com \
    --cc=cjb@laptop.org \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=sudhakar.raj@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox