From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect Date: Wed, 7 Mar 2012 09:31:52 -0800 Message-ID: <20120307173152.GG12083@atomide.com> References: <20120301185044.29210.44521.stgit@kaulin.local> <20120301185535.29210.71546.stgit@kaulin.local> <4F50643B.9050500@ti.com> <20120302172251.GJ18901@atomide.com> <4F548457.5050205@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:60129 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758219Ab2CGRb6 (ORCPT ); Wed, 7 Mar 2012 12:31:58 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball Cc: "T Krishnamoorthy, Balaji" , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Samuel Ortiz , Rajendra Nayak * Chris Ball [120307 07:11]: > Hi Balaji, > > On Wed, Mar 07 2012, T Krishnamoorthy, Balaji wrote: > > OMAP4 and OMAP3 HSMMC IP registers differ by 0x100 offset. > > Addng the offset to platform_device resource structure > > increments the start address for every insmod operation. > > MMC command fails on re-insertion as module due incorrect register base. > > Fix this by updating the ioremap base address only. > > > > Signed-off-by: Balaji T K > > Is this a regression, or has it never worked in mainline? "Features that never worked originally" so this can wait for the merge window. It happens on re-inserting of the card. > > Note: eMMC detection is still failing on resertion due to card vcc > > power off on rmmod > > And this? That sounds like a separate issue that needs to be fixed. Regards, Tony