From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-samsung-soc@vger.kernel.org, "Chris Ball" <cjb@laptop.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"kgene kim" <kgene.kim@samsung.com>
Subject: Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file
Date: Wed, 7 Mar 2012 18:48:44 +0000 [thread overview]
Message-ID: <20120307184843.GW3107@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F56D003.5070406@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
On Wed, Mar 07, 2012 at 12:03:31PM +0900, Jaehoon Chung wrote:
> On 03/07/2012 01:30 AM, Mark Brown wrote:
> > The same IP is present and used with the same driver on other Samsung
> > SoCs.
> I know that used with the same driver on other Samsung-SoCs(S3C64XX/S3C24XX..etc)
> I just only used the interface in sdhci-pltfm.c. Nothing difference..
> Why do you think that will break the other SoC?
> Header file(/plat/regs-sdhci.h) also is only used in sdhci-s3c.c.
> And the least portion is moved into /linux/mmc/.
> Then included "linux/mmc/sdhci-s3c.h" in plat/sdhci.h.
> What's difference?
> If you can explain the more detail, i can understand.
> But sorry, now i didn't accept your opinion.
To be honest I didn't read the series, the diffstat looks so obviously
problematic as you're touching the setup-gpio- files for only a subset
of Samsung architectures - there's been quite regular issues with
updates for newer SoCs breaking support for s3c64xx.
I also notice that this will conflict with the series I've previously
posted for runtime PM support which would push us even further back from
being able to use the lower power WFI modes in mainline :( Though
hopefully that'll be easier to fix.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-07 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 6:17 [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file Jaehoon Chung
2012-03-06 13:00 ` Mark Brown
2012-03-06 13:15 ` Heiko Stübner
2012-03-06 14:40 ` Jae hoon Chung
2012-03-06 16:30 ` Mark Brown
2012-03-07 3:03 ` Jaehoon Chung
2012-03-07 18:48 ` Mark Brown [this message]
2012-03-08 5:35 ` Jaehoon Chung
2012-03-08 11:01 ` Mark Brown
2012-03-09 1:53 ` Jaehoon Chung
2012-03-09 11:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307184843.GW3107@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).