From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v1 2/5] mmc: mxs-mmc: add dt probe support Date: Wed, 14 Mar 2012 08:09:22 +0100 Message-ID: <201203140809.22676.marek.vasut@gmail.com> References: <1331628428-24017-1-git-send-email-b29396@freescale.com> <201203140658.25854.marek.vasut@gmail.com> <20120314065512.GB25735@shlinux2.ap.freescale.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:45808 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149Ab2CNHJZ (ORCPT ); Wed, 14 Mar 2012 03:09:25 -0400 In-Reply-To: <20120314065512.GB25735@shlinux2.ap.freescale.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Dong Aisheng Cc: "linux-arm-kernel@lists.infradead.org" , Dong Aisheng-B29396 , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "vinod.koul@linux.intel.com" , "s.hauer@pengutronix.de" , "rob.herring@calxeda.com" , "grant.likely@secretlab.ca" , "rdunlap@xenotime.net" , "kernel@pengutronix.de" , "cjb@laptop.org" , Guo Shawn-R65073 Dear Dong Aisheng, > On Wed, Mar 14, 2012 at 01:58:25PM +0800, Marek Vasut wrote: > > Dear Dong Aisheng, > > > > > Signed-off-by: Dong Aisheng > > ........ > > > > +static const struct of_device_id mxs_mmc_dt_ids[] = { > > > + { .compatible = "fsl,imx23-mmc", .data = NULL, }, > > > + { .compatible = "fsl,imx28-mmc", .data = NULL, }, > > > > Do you really need two distinct ones here? > > Hmm, my original purpose is to put soc difference data in .data > to remove cpu_is_* function calls in the driver later. > Do you think if any issue? > Well, what's the difference between the interfaces on mx233 and mx28? Is it something that can't be encoded otherwise? I think they're not so different. Best regards, Marek Vasut