From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [PATCH v1 1/5] ARM: imx28: add basic dt support Date: Thu, 15 Mar 2012 18:59:28 +0800 Message-ID: <20120315105927.GE13022@shlinux2.ap.freescale.net> References: <1331628428-24017-1-git-send-email-b29396@freescale.com> <1331628428-24017-2-git-send-email-b29396@freescale.com> <20120313172351.97C5E3E053B@localhost> <20120314124512.GG1180@shlinux2.ap.freescale.net> <20120314141643.GP3852@pengutronix.de> <20120315030206.GB13022@shlinux2.ap.freescale.net> <20321.37353.63115.664975@ipc1.ka-ro> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from am1ehsobe006.messaging.microsoft.com ([213.199.154.209]:22041 "EHLO am1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756159Ab2COK6I convert rfc822-to-8bit (ORCPT ); Thu, 15 Mar 2012 06:58:08 -0400 Content-Disposition: inline In-Reply-To: <20321.37353.63115.664975@ipc1.ka-ro> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: Dong Aisheng-B29396 , "s.hauer@pengutronix.de" , Guo Shawn-R65073 , "vinod.koul@linux.intel.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , Grant Likely , "rdunlap@xenotime.net" , "kernel@pengutronix.de" , "cjb@laptop.org" , "linux-arm-kernel@lists.infradead.org" On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Wa=DFmann wrote: > Hi, >=20 > Dong Aisheng writes: > > On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.hauer@pengutronix.de wr= ote: > > > On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote: > > > > On Wed, Mar 14, 2012 at 01:23:51AM +0800, Grant Likely wrote: > [...] > > > > But it seems this needs pass mac address to fec driver via plat= forom data which is > > > > not friendly to dt. > > > >=20 > > > > Another way may be changing fec driver to get the fixed part of= mac address(first > > > > two bytes) from device tree and read the left dynamical part fr= om otp which i'm not > > > > sure is better enough. > > > >=20 > > > > BTW, filling with zeros seems not work since it's invalid mac a= ddress. > > >=20 > > > Yes, that's the idea of using this value... > > >=20 > > But comparing to use an invalid value, why not just do not define t= hat > > local-mac-address property? > >=20 > Because a MAC address is by definition a GLOBALLY UNIQUE IDENTIFIER > which is contrary to coding a "valid" default value for it somewhere! > The owner of a certain MAC address range (OUI) is responsible for > ensuring the uniqueness. Thus only they may assign a specific MAC > address to a specific device. >=20 Yes, you're correct. So i propose to read the MAC address from MX28 OTP in fec driver instea= d of define it in device tree in my last mail. http://www.spinics.net/lists/arm-kernel/msg165040.html Do you have any comment on that way? Regards Dong Aisheng