public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Chris Ball <cjb@laptop.org>
Cc: Paul Walmsley <paul@pwsan.com>,
	Chase Maupin <Chase.Maupin@ti.com>,
	linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
	sakoman@gmail.com
Subject: Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices
Date: Thu, 5 Apr 2012 15:08:48 -0700	[thread overview]
Message-ID: <20120405220848.GF3785@atomide.com> (raw)
In-Reply-To: <87bonxcjrh.fsf@laptop.org>

* Chris Ball <cjb@laptop.org> [120315 20:26]:
> Hi Paul,
> 
> On Mon, Mar 12 2012, Paul Walmsley wrote:
> > I don't think this is the right fix.  Steve Sakoman and I discussed this a 
> > few months ago -- we did some debugging and Steve observed the timeouts on 
> > multiple block writes (0x19):
> > [...]
> > So perhaps something like the following patch instead?  Unfortunately, I 
> > don't have one of these crappy SD cards as far as I know, so I can't 
> > really test it.
> >
> >
> > - Paul
> >
> > From: Paul Walmsley <paul@pwsan.com>
> > Date: Mon, 12 Mar 2012 04:46:29 -0600
> > Subject: [PATCH] mmc: use really long write timeout to deal with crappy cards
> >
> > Several people have noticed that crappy SD cards take much longer to
> > complete multiple block writes than the 300ms that Linux specifies.
> > Try to work around this by using a three second write timeout instead.
> >
> > <insert Chase's patch description here>
> >
> > Not-yet-signed-off-by: Paul Walmsley <paul@pwsan.com>
> 
> Sounds like a good idea -- want to send a signed-off patch for this?

This seems like the right fix to me too. Works on my pandaboard es and
some random card that produces I/O errors without this.

Tested-by: Tony Lindgren <tony@atomide.com>

  reply	other threads:[~2012-04-05 22:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 17:26 [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices Chase Maupin
2012-03-06 12:54 ` Maupin, Chase
2012-03-09  4:38 ` Chris Ball
2012-03-09 13:06   ` Maupin, Chase
2012-03-12 10:58   ` Paul Walmsley
2012-03-12 11:10     ` Paul Walmsley
2012-03-12 14:37     ` Maupin, Chase
2012-03-16  3:22     ` Chris Ball
2012-04-05 22:08       ` Tony Lindgren [this message]
2012-04-05 22:15         ` Chris Ball
2012-04-05 23:44           ` Paul Walmsley
2012-04-05 23:54             ` Chris Ball
2012-04-12  9:46               ` Tushar Behera
2012-04-12 17:56                 ` Paul Walmsley
2012-04-12 18:19                   ` Chris Ball
2012-04-14  9:38                     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120405220848.GF3785@atomide.com \
    --to=tony@atomide.com \
    --cc=Chase.Maupin@ti.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox