From: Marek Vasut <marex@denx.de>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, "Shawn Guo" <shawn.guo@linaro.org>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
"Lothar Waßmann" <LW@karo-electronics.de>
Subject: Re: [PATCH] mmc: mxs-mmc: Add wp-inverted property
Date: Thu, 19 Jul 2012 17:06:05 +0200 [thread overview]
Message-ID: <201207191706.06058.marex@denx.de> (raw)
In-Reply-To: <87hat394lp.fsf@octavius.laptop.org>
Dear Chris Ball,
> Hi Marek,
>
> On Fri, Jun 08 2012, Marek Vasut wrote:
> > The write-protect GPIO is inverted on some boards. Handle such case.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: linux-mmc@vger.kernel.org
> > Cc: Chris Ball <cjb@laptop.org>
> > Cc: Lothar Waßmann <LW@karo-electronics.de>
> > ---
> >
> > drivers/mmc/host/mxs-mmc.c | 15 +++++++++++++--
> > 1 file changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> > index 34a9026..c6964e1 100644
> > --- a/drivers/mmc/host/mxs-mmc.c
> > +++ b/drivers/mmc/host/mxs-mmc.c
> > @@ -164,16 +164,23 @@ struct mxs_mmc_host {
> >
> > spinlock_t lock;
> > int sdio_irq_en;
> > int wp_gpio;
> >
> > + int wp_inverted:1;
>
> Mind if I change this to "bool wp_inverted;"? Other than that, looks
> fine and I'll merge it for 3.6.
That should be fine. Thanks!
> Thanks,
>
> - Chris.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-19 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 18:55 [PATCH] mmc: mxs-mmc: Add wp-inverted property Marek Vasut
2012-07-19 11:50 ` Marek Vasut
2012-07-19 15:02 ` Chris Ball
2012-07-19 15:06 ` Marek Vasut [this message]
2012-07-19 15:12 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 21:01 Marek Vasut
2012-05-21 21:17 ` Guennadi Liakhovetski
2012-05-21 3:36 Marek Vasut
2012-05-21 3:45 ` Chris Ball
2012-05-21 3:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207191706.06058.marex@denx.de \
--to=marex@denx.de \
--cc=LW@karo-electronics.de \
--cc=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).