From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] mmc: sdio: Fix PM_SLEEP related build warnings Date: Thu, 9 Aug 2012 11:55:34 +0200 Message-ID: <201208091155.34573.rjw@sisk.pl> References: <1344495413-7164-1-git-send-email-thierry.reding@avionic-design.de> <201208091127.03119.rjw@sisk.pl> <20120809092756.GA1020@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([193.178.161.156]:50311 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440Ab2HIJtk (ORCPT ); Thu, 9 Aug 2012 05:49:40 -0400 In-Reply-To: <20120809092756.GA1020@avionic-0098.mockup.avionic-design.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Thierry Reding Cc: Chris Ball , Paul Gortmaker , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org On Thursday, August 09, 2012, Thierry Reding wrote: > On Thu, Aug 09, 2012 at 11:27:02AM +0200, Rafael J. Wysocki wrote: > > On Thursday, August 09, 2012, Thierry Reding wrote: > > > Power management callbacks defined by SIMPLE_DEV_PM_OPS are only used if > > > the PM_SLEEP Kconfig symbol has been defined. If not, the compiler will > > > complain about them being unused. > > > > > > Signed-off-by: Thierry Reding > > > > The pm_no_operation() thing is not necessary at all, AFAICT. I'd just > > remove it entirely. :-) > > I don't actually have a setup where I can test suspend/resume with this > driver, but if you say so I can follow up with a patch that removes > pm_no_operation(). It should work because many drivers without proper > PM_SLEEP support do not specify .suspend() nor .resume() callbacks > either. Sure, it should work. Thanks, Rafael