From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API Date: Thu, 30 Aug 2012 10:43:07 -0400 Message-ID: <20120830144307.GA26737@beef> References: <1345684176-21472-1-git-send-email-mporter@ti.com> <1345684176-21472-4-git-send-email-mporter@ti.com> <503F75C0.1050507@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:34437 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453Ab2H3Omi (ORCPT ); Thu, 30 Aug 2012 10:42:38 -0400 Content-Disposition: inline In-Reply-To: <503F75C0.1050507@ti.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Sekhar Nori Cc: Linux DaVinci Kernel List , vinod.koul@intel.com, Linux MMC List , Linux Kernel Mailing List , grant.likely@secretlab.ca, Linux SPI Devel List , cjb@laptop.org, Linux ARM Kernel List On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: > Hi Matt, > > On 8/23/2012 6:39 AM, Matt Porter wrote: > > Removes use of the DaVinci EDMA private DMA API and replaces > > it with use of the DMA engine API. > > > > Signed-off-by: Matt Porter > > I tried testing this patch on my OMAP-L138 EVM, but SPI fails to > initialize after applying the patch. > > root@arago:~# dmesg | grep -i spi > spi_davinci spi_davinci.1: request RX DMA channel failed Hi Sekhar, Most likely CONFIG_TI_EDMA is off as it defaults to off in the v3 series. Try enabling this and if it's the problem then this error path can be fixed to properly fallback to PIO only or fail to initialize as needed. -Matt