From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] avr32-linux: at32ap700x: set DMA slave properties for MCI dw_dmac Date: Fri, 31 Aug 2012 16:44:35 -0700 Message-ID: <20120831164435.a1b72191.akpm@linux-foundation.org> References: <503A8D97.4070403@yahoo.es> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <503A8D97.4070403@yahoo.es> Sender: linux-kernel-owner@vger.kernel.org To: Hein Tibosch Cc: egtvedt@samfundet.no, Linux Kernel Mailing List , Nicolas Ferre , "ludovic.desroches" , Havard Skinnemoen , "linux-mmc@vger.kernel.org" , Chris Ball List-Id: linux-mmc@vger.kernel.org On Mon, 27 Aug 2012 04:56:55 +0800 Hein Tibosch wrote: > The MCI makes use of the dw_dmac driver when DMA is being used. > Due to recent changes the driver was broken because: > - the SMS field in the CTLL register received the wrong value 0 > - a patch in dw_dmac allowed for 64-bit transfers on the > memory side, giving an illegal value of 3 in the SRC/DST_TR_WIDTH > register. Please try to avoid vague descriptions such as "recent changes" and "a patch". We like to see specifics: commit IDs and titles. This way we can make more informed decisions about patch scheduling. We can ensure that the authors of the earlier commits get to review these changes. Maintainers of other trees can determine whether or not their tree needs the particular fix.