From: Pavel Machek <pavel@ucw.cz>
To: Theodore Ts'o <tytso@mit.edu>, Matt Sealey <matt@genesi-usa.com>,
Mike Thompson <mpthompson@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>,
Linux-Arm-Kernel <linux-arm-kernel@lists.infradead.org>,
linux-ext4@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Tracking down suspend/resume ext3/mmc issues on imx233
Date: Thu, 20 Sep 2012 01:23:49 +0200 [thread overview]
Message-ID: <20120919232349.GA24132@elf.ucw.cz> (raw)
In-Reply-To: <20120910163345.GB3942@thunk.org>
On Mon 2012-09-10 12:33:45, Theodore Ts'o wrote:
> On Mon, Sep 10, 2012 at 10:11:48AM -0500, Matt Sealey wrote:
> > Wouldn't it be better if the root filesystem was marked as
> > non-removable in the device tree - or in the case of a truly removable
> > card, just marked in the MMC subsystem - and the MMC subsystem skipped
> > the "it could be removed" for suspend/resume operations?
>
> I agree, this makes a lot of sense. If the root file system
> disappears, you're toasted either way, so it's fair to assume that the
> device on which the root file system is located should is
> non-removable.
I'm not sure I agree.
If you treat root fs as removable, you'll get "crash". You'll need to
replay the journal, but data is safe.
If you treat it as non-removable, and someone manages to remove it,
mount, and reinsert, you'll get silent data corruption.
If the card is not removable, mark it as such...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2012-09-19 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEOSq-O3SfuAEhMsjX1y1ZgQuWBKef+XZzMR1b4yJhKhaRdymA@mail.gmail.com>
2012-09-07 6:05 ` Tracking down suspend/resume ext3/mmc issues on imx233 Shawn Guo
2012-09-08 16:17 ` Mike Thompson
2012-09-10 15:11 ` Matt Sealey
2012-09-10 16:33 ` Theodore Ts'o
2012-09-19 23:23 ` Pavel Machek [this message]
2012-09-20 0:01 ` Theodore Ts'o
2012-09-22 19:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919232349.GA24132@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@genesi-usa.com \
--cc=mpthompson@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox