* [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
@ 2012-09-26 6:02 r66093
2012-09-26 13:03 ` Girish K S
0 siblings, 1 reply; 7+ messages in thread
From: r66093 @ 2012-09-26 6:02 UTC (permalink / raw)
To: linux-mmc; +Cc: Jerry Huang, Shaohui Xie, Anton Vorontsov, Chris Ball
From: Jerry Huang <Chang-Ming.Huang@freescale.com>
CMD23 causes lots of errors in kernel on some freescale SoCs
(P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used,
which is because these controllers does not support CMD23,
even on the SoCs which declares CMD23 is supported.
Therefore, we'll not use CMD23.
Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
CC: Anton Vorontsov <cbouatmailru@gmail.com>
CC: Chris Ball <cjb@laptop.org>
---
changes for v5:
- change the error to warning information
changes for v4:
- change to detect the IP version
- don't use callback function
changes for v3:
- move the limitation detect function to eSDHC file
- add the callback funtion to do this limitation detect
changes for v2:
- discard the property mode and add the processor detection
drivers/mmc/host/sdhci-of-esdhc.c | 33 +++++++++++++++++++++++++++++++++
drivers/mmc/host/sdhci-pltfm.c | 4 +++-
drivers/mmc/host/sdhci-pltfm.h | 1 +
drivers/mmc/host/sdhci.c | 3 +++
include/linux/mmc/sdhci.h | 1 +
5 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index ae5fcbf..ffc1226 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -169,6 +169,38 @@ static void esdhc_of_resume(struct sdhci_host *host)
}
#endif
+static void esdhc_of_detect_limitation(struct platform_device *pdev,
+ struct sdhci_pltfm_data *pdata)
+{
+ void __iomem *ioaddr;
+ struct resource *iomem;
+ u32 vvn;
+
+ iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!iomem) {
+ dev_warn(&pdev->dev, "failed to get resource\n");
+ goto end;
+ }
+ if (resource_size(iomem) < 0x100)
+ dev_warn(&pdev->dev, "Invalid iomem size!\n");
+
+ ioaddr = ioremap(iomem->start, resource_size(iomem));
+ if (!ioaddr) {
+ dev_warn(&pdev->dev, "failed to remap registers\n");
+ goto end;
+ }
+
+ /* P102x and P4080 has IP version VVN2.2, CMD23 is not supported */
+ vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
+ vvn = (vvn & SDHCI_VENDOR_VER_MASK) >> SDHCI_VENDOR_VER_SHIFT;
+ if (vvn == VENDOR_V_22)
+ pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
+
+ iounmap(ioaddr);
+end:
+ return;
+}
+
static struct sdhci_ops sdhci_esdhc_ops = {
.read_l = esdhc_readl,
.read_w = esdhc_readw,
@@ -199,6 +231,7 @@ static struct sdhci_pltfm_data sdhci_esdhc_pdata = {
static int __devinit sdhci_esdhc_probe(struct platform_device *pdev)
{
+ esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata);
}
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 65551a9..4dd5770 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -132,8 +132,10 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
host->ops = pdata->ops;
else
host->ops = &sdhci_pltfm_ops;
- if (pdata)
+ if (pdata) {
host->quirks = pdata->quirks;
+ host->quirks2 = pdata->quirks2;
+ }
host->irq = platform_get_irq(pdev, 0);
if (!request_mem_region(iomem->start, resource_size(iomem),
diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
index 37e0e18..283d54a 100644
--- a/drivers/mmc/host/sdhci-pltfm.h
+++ b/drivers/mmc/host/sdhci-pltfm.h
@@ -18,6 +18,7 @@
struct sdhci_pltfm_data {
struct sdhci_ops *ops;
unsigned int quirks;
+ unsigned int quirks2;
};
struct sdhci_pltfm_host {
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 0e15c79..b0b7cad 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2837,6 +2837,9 @@ int sdhci_add_host(struct sdhci_host *host)
if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
mmc->caps |= MMC_CAP_4_BIT_DATA;
+ if (host->quirks2 & SDHCI_QUIRK2_HOST_NO_CMD23)
+ mmc->caps &= ~MMC_CAP_CMD23;
+
if (caps[0] & SDHCI_CAN_DO_HISPD)
mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
index fa8529a..1edcb4d 100644
--- a/include/linux/mmc/sdhci.h
+++ b/include/linux/mmc/sdhci.h
@@ -91,6 +91,7 @@ struct sdhci_host {
unsigned int quirks2; /* More deviations from spec. */
#define SDHCI_QUIRK2_HOST_OFF_CARD_ON (1<<0)
+#define SDHCI_QUIRK2_HOST_NO_CMD23 (1<<1)
int irq; /* Device IRQ */
void __iomem *ioaddr; /* Mapped address */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
2012-09-26 6:02 [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs r66093
@ 2012-09-26 13:03 ` Girish K S
2012-10-09 6:24 ` Huang Changming-R66093
0 siblings, 1 reply; 7+ messages in thread
From: Girish K S @ 2012-09-26 13:03 UTC (permalink / raw)
To: r66093; +Cc: linux-mmc, Jerry Huang, Shaohui Xie, Anton Vorontsov, Chris Ball
Looks good
Reviewed By:- Girish K S <girish.shivananjappa@linaro.org>
On 26 September 2012 15:02, <r66093@freescale.com> wrote:
> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
>
> CMD23 causes lots of errors in kernel on some freescale SoCs
> (P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used,
> which is because these controllers does not support CMD23,
> even on the SoCs which declares CMD23 is supported.
> Therefore, we'll not use CMD23.
>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> CC: Anton Vorontsov <cbouatmailru@gmail.com>
> CC: Chris Ball <cjb@laptop.org>
> ---
> changes for v5:
> - change the error to warning information
> changes for v4:
> - change to detect the IP version
> - don't use callback function
> changes for v3:
> - move the limitation detect function to eSDHC file
> - add the callback funtion to do this limitation detect
> changes for v2:
> - discard the property mode and add the processor detection
>
> drivers/mmc/host/sdhci-of-esdhc.c | 33 +++++++++++++++++++++++++++++++++
> drivers/mmc/host/sdhci-pltfm.c | 4 +++-
> drivers/mmc/host/sdhci-pltfm.h | 1 +
> drivers/mmc/host/sdhci.c | 3 +++
> include/linux/mmc/sdhci.h | 1 +
> 5 files changed, 41 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index ae5fcbf..ffc1226 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -169,6 +169,38 @@ static void esdhc_of_resume(struct sdhci_host *host)
> }
> #endif
>
> +static void esdhc_of_detect_limitation(struct platform_device *pdev,
> + struct sdhci_pltfm_data *pdata)
> +{
> + void __iomem *ioaddr;
> + struct resource *iomem;
> + u32 vvn;
> +
> + iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!iomem) {
> + dev_warn(&pdev->dev, "failed to get resource\n");
> + goto end;
> + }
> + if (resource_size(iomem) < 0x100)
> + dev_warn(&pdev->dev, "Invalid iomem size!\n");
> +
> + ioaddr = ioremap(iomem->start, resource_size(iomem));
> + if (!ioaddr) {
> + dev_warn(&pdev->dev, "failed to remap registers\n");
> + goto end;
> + }
> +
> + /* P102x and P4080 has IP version VVN2.2, CMD23 is not supported */
> + vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
> + vvn = (vvn & SDHCI_VENDOR_VER_MASK) >> SDHCI_VENDOR_VER_SHIFT;
> + if (vvn == VENDOR_V_22)
> + pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> +
> + iounmap(ioaddr);
> +end:
> + return;
> +}
> +
> static struct sdhci_ops sdhci_esdhc_ops = {
> .read_l = esdhc_readl,
> .read_w = esdhc_readw,
> @@ -199,6 +231,7 @@ static struct sdhci_pltfm_data sdhci_esdhc_pdata = {
>
> static int __devinit sdhci_esdhc_probe(struct platform_device *pdev)
> {
> + esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
> return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata);
> }
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index 65551a9..4dd5770 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -132,8 +132,10 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
> host->ops = pdata->ops;
> else
> host->ops = &sdhci_pltfm_ops;
> - if (pdata)
> + if (pdata) {
> host->quirks = pdata->quirks;
> + host->quirks2 = pdata->quirks2;
> + }
> host->irq = platform_get_irq(pdev, 0);
>
> if (!request_mem_region(iomem->start, resource_size(iomem),
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index 37e0e18..283d54a 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -18,6 +18,7 @@
> struct sdhci_pltfm_data {
> struct sdhci_ops *ops;
> unsigned int quirks;
> + unsigned int quirks2;
> };
>
> struct sdhci_pltfm_host {
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 0e15c79..b0b7cad 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2837,6 +2837,9 @@ int sdhci_add_host(struct sdhci_host *host)
> if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> mmc->caps |= MMC_CAP_4_BIT_DATA;
>
> + if (host->quirks2 & SDHCI_QUIRK2_HOST_NO_CMD23)
> + mmc->caps &= ~MMC_CAP_CMD23;
> +
> if (caps[0] & SDHCI_CAN_DO_HISPD)
> mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>
> diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
> index fa8529a..1edcb4d 100644
> --- a/include/linux/mmc/sdhci.h
> +++ b/include/linux/mmc/sdhci.h
> @@ -91,6 +91,7 @@ struct sdhci_host {
> unsigned int quirks2; /* More deviations from spec. */
>
> #define SDHCI_QUIRK2_HOST_OFF_CARD_ON (1<<0)
> +#define SDHCI_QUIRK2_HOST_NO_CMD23 (1<<1)
>
> int irq; /* Device IRQ */
> void __iomem *ioaddr; /* Mapped address */
> --
> 1.7.9.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
2012-09-26 13:03 ` Girish K S
@ 2012-10-09 6:24 ` Huang Changming-R66093
2012-10-15 3:07 ` Huang Changming-R66093
2012-10-24 8:39 ` Anton Vorontsov
0 siblings, 2 replies; 7+ messages in thread
From: Huang Changming-R66093 @ 2012-10-09 6:24 UTC (permalink / raw)
To: Anton Vorontsov, Chris Ball
Cc: linux-mmc@vger.kernel.org, Xie Shaohui-B21989, Girish K S
Hi, Anto and Chris
This version was created with the feedback from Kumar and all of you.
Have you any comment about this patch?
Could it be merged into kernel?
Best Regards
Jerry Huang
> -----Original Message-----
> From: Girish K S [mailto:girish.shivananjappa@linaro.org]
> Sent: Wednesday, September 26, 2012 9:04 PM
> To: Huang Changming-R66093
> Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie Shaohui-B21989;
> Anton Vorontsov; Chris Ball
> Subject: Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale
> SoCs
>
> Looks good
> Reviewed By:- Girish K S <girish.shivananjappa@linaro.org>
>
> On 26 September 2012 15:02, <r66093@freescale.com> wrote:
> > From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> >
> > CMD23 causes lots of errors in kernel on some freescale SoCs (P1020,
> > P1021, P1022, P1024, P1025 and P4080) when MMC card used, which is
> > because these controllers does not support CMD23, even on the SoCs
> > which declares CMD23 is supported.
> > Therefore, we'll not use CMD23.
> >
> > Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > CC: Anton Vorontsov <cbouatmailru@gmail.com>
> > CC: Chris Ball <cjb@laptop.org>
> > ---
> > changes for v5:
> > - change the error to warning information changes for v4:
> > - change to detect the IP version
> > - don't use callback function
> > changes for v3:
> > - move the limitation detect function to eSDHC file
> > - add the callback funtion to do this limitation detect
> > changes for v2:
> > - discard the property mode and add the processor detection
> >
> > drivers/mmc/host/sdhci-of-esdhc.c | 33
> +++++++++++++++++++++++++++++++++
> > drivers/mmc/host/sdhci-pltfm.c | 4 +++-
> > drivers/mmc/host/sdhci-pltfm.h | 1 +
> > drivers/mmc/host/sdhci.c | 3 +++
> > include/linux/mmc/sdhci.h | 1 +
> > 5 files changed, 41 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-of-esdhc.c
> > b/drivers/mmc/host/sdhci-of-esdhc.c
> > index ae5fcbf..ffc1226 100644
> > --- a/drivers/mmc/host/sdhci-of-esdhc.c
> > +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> > @@ -169,6 +169,38 @@ static void esdhc_of_resume(struct sdhci_host
> > *host) } #endif
> >
> > +static void esdhc_of_detect_limitation(struct platform_device *pdev,
> > + struct sdhci_pltfm_data *pdata) {
> > + void __iomem *ioaddr;
> > + struct resource *iomem;
> > + u32 vvn;
> > +
> > + iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > + if (!iomem) {
> > + dev_warn(&pdev->dev, "failed to get resource\n");
> > + goto end;
> > + }
> > + if (resource_size(iomem) < 0x100)
> > + dev_warn(&pdev->dev, "Invalid iomem size!\n");
> > +
> > + ioaddr = ioremap(iomem->start, resource_size(iomem));
> > + if (!ioaddr) {
> > + dev_warn(&pdev->dev, "failed to remap registers\n");
> > + goto end;
> > + }
> > +
> > + /* P102x and P4080 has IP version VVN2.2, CMD23 is not
> supported */
> > + vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
> > + vvn = (vvn & SDHCI_VENDOR_VER_MASK) >> SDHCI_VENDOR_VER_SHIFT;
> > + if (vvn == VENDOR_V_22)
> > + pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> > +
> > + iounmap(ioaddr);
> > +end:
> > + return;
> > +}
> > +
> > static struct sdhci_ops sdhci_esdhc_ops = {
> > .read_l = esdhc_readl,
> > .read_w = esdhc_readw,
> > @@ -199,6 +231,7 @@ static struct sdhci_pltfm_data sdhci_esdhc_pdata =
> > {
> >
> > static int __devinit sdhci_esdhc_probe(struct platform_device *pdev)
> > {
> > + esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
> > return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata); }
> >
> > diff --git a/drivers/mmc/host/sdhci-pltfm.c
> > b/drivers/mmc/host/sdhci-pltfm.c index 65551a9..4dd5770 100644
> > --- a/drivers/mmc/host/sdhci-pltfm.c
> > +++ b/drivers/mmc/host/sdhci-pltfm.c
> > @@ -132,8 +132,10 @@ struct sdhci_host *sdhci_pltfm_init(struct
> platform_device *pdev,
> > host->ops = pdata->ops;
> > else
> > host->ops = &sdhci_pltfm_ops;
> > - if (pdata)
> > + if (pdata) {
> > host->quirks = pdata->quirks;
> > + host->quirks2 = pdata->quirks2;
> > + }
> > host->irq = platform_get_irq(pdev, 0);
> >
> > if (!request_mem_region(iomem->start, resource_size(iomem),
> > diff --git a/drivers/mmc/host/sdhci-pltfm.h
> > b/drivers/mmc/host/sdhci-pltfm.h index 37e0e18..283d54a 100644
> > --- a/drivers/mmc/host/sdhci-pltfm.h
> > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > @@ -18,6 +18,7 @@
> > struct sdhci_pltfm_data {
> > struct sdhci_ops *ops;
> > unsigned int quirks;
> > + unsigned int quirks2;
> > };
> >
> > struct sdhci_pltfm_host {
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index
> > 0e15c79..b0b7cad 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -2837,6 +2837,9 @@ int sdhci_add_host(struct sdhci_host *host)
> > if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> > mmc->caps |= MMC_CAP_4_BIT_DATA;
> >
> > + if (host->quirks2 & SDHCI_QUIRK2_HOST_NO_CMD23)
> > + mmc->caps &= ~MMC_CAP_CMD23;
> > +
> > if (caps[0] & SDHCI_CAN_DO_HISPD)
> > mmc->caps |= MMC_CAP_SD_HIGHSPEED |
> > MMC_CAP_MMC_HIGHSPEED;
> >
> > diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
> > index fa8529a..1edcb4d 100644
> > --- a/include/linux/mmc/sdhci.h
> > +++ b/include/linux/mmc/sdhci.h
> > @@ -91,6 +91,7 @@ struct sdhci_host {
> > unsigned int quirks2; /* More deviations from spec. */
> >
> > #define SDHCI_QUIRK2_HOST_OFF_CARD_ON (1<<0)
> > +#define SDHCI_QUIRK2_HOST_NO_CMD23 (1<<1)
> >
> > int irq; /* Device IRQ */
> > void __iomem *ioaddr; /* Mapped address */
> > --
> > 1.7.9.5
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
2012-10-09 6:24 ` Huang Changming-R66093
@ 2012-10-15 3:07 ` Huang Changming-R66093
2012-10-23 8:41 ` Huang Changming-R66093
2012-10-24 8:39 ` Anton Vorontsov
1 sibling, 1 reply; 7+ messages in thread
From: Huang Changming-R66093 @ 2012-10-15 3:07 UTC (permalink / raw)
To: Huang Changming-R66093, Anton Vorontsov, Chris Ball
Cc: linux-mmc@vger.kernel.org, Xie Shaohui-B21989, Girish K S
Anton,
Have you any comment about this patch?
Best Regards
Jerry Huang
> -----Original Message-----
> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> owner@vger.kernel.org] On Behalf Of Huang Changming-R66093
> Sent: Tuesday, October 09, 2012 2:24 PM
> To: Anton Vorontsov; Chris Ball
> Cc: linux-mmc@vger.kernel.org; Xie Shaohui-B21989; Girish K S
> Subject: RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale
> SoCs
>
> Hi, Anto and Chris
> This version was created with the feedback from Kumar and all of you.
> Have you any comment about this patch?
> Could it be merged into kernel?
>
> Best Regards
> Jerry Huang
>
> > -----Original Message-----
> > From: Girish K S [mailto:girish.shivananjappa@linaro.org]
> > Sent: Wednesday, September 26, 2012 9:04 PM
> > To: Huang Changming-R66093
> > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie
> > Shaohui-B21989; Anton Vorontsov; Chris Ball
> > Subject: Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some
> > Freescale SoCs
> >
> > Looks good
> > Reviewed By:- Girish K S <girish.shivananjappa@linaro.org>
> >
> > On 26 September 2012 15:02, <r66093@freescale.com> wrote:
> > > From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> > >
> > > CMD23 causes lots of errors in kernel on some freescale SoCs (P1020,
> > > P1021, P1022, P1024, P1025 and P4080) when MMC card used, which is
> > > because these controllers does not support CMD23, even on the SoCs
> > > which declares CMD23 is supported.
> > > Therefore, we'll not use CMD23.
> > >
> > > Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > CC: Anton Vorontsov <cbouatmailru@gmail.com>
> > > CC: Chris Ball <cjb@laptop.org>
> > > ---
> > > changes for v5:
> > > - change the error to warning information changes for v4:
> > > - change to detect the IP version
> > > - don't use callback function changes for v3:
> > > - move the limitation detect function to eSDHC file
> > > - add the callback funtion to do this limitation detect
> > > changes for v2:
> > > - discard the property mode and add the processor detection
> > >
> > > drivers/mmc/host/sdhci-of-esdhc.c | 33
> > +++++++++++++++++++++++++++++++++
> > > drivers/mmc/host/sdhci-pltfm.c | 4 +++-
> > > drivers/mmc/host/sdhci-pltfm.h | 1 +
> > > drivers/mmc/host/sdhci.c | 3 +++
> > > include/linux/mmc/sdhci.h | 1 +
> > > 5 files changed, 41 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mmc/host/sdhci-of-esdhc.c
> > > b/drivers/mmc/host/sdhci-of-esdhc.c
> > > index ae5fcbf..ffc1226 100644
> > > --- a/drivers/mmc/host/sdhci-of-esdhc.c
> > > +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> > > @@ -169,6 +169,38 @@ static void esdhc_of_resume(struct sdhci_host
> > > *host) } #endif
> > >
> > > +static void esdhc_of_detect_limitation(struct platform_device *pdev,
> > > + struct sdhci_pltfm_data *pdata) {
> > > + void __iomem *ioaddr;
> > > + struct resource *iomem;
> > > + u32 vvn;
> > > +
> > > + iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > + if (!iomem) {
> > > + dev_warn(&pdev->dev, "failed to get resource\n");
> > > + goto end;
> > > + }
> > > + if (resource_size(iomem) < 0x100)
> > > + dev_warn(&pdev->dev, "Invalid iomem size!\n");
> > > +
> > > + ioaddr = ioremap(iomem->start, resource_size(iomem));
> > > + if (!ioaddr) {
> > > + dev_warn(&pdev->dev, "failed to remap registers\n");
> > > + goto end;
> > > + }
> > > +
> > > + /* P102x and P4080 has IP version VVN2.2, CMD23 is not
> > supported */
> > > + vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
> > > + vvn = (vvn & SDHCI_VENDOR_VER_MASK) >> SDHCI_VENDOR_VER_SHIFT;
> > > + if (vvn == VENDOR_V_22)
> > > + pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> > > +
> > > + iounmap(ioaddr);
> > > +end:
> > > + return;
> > > +}
> > > +
> > > static struct sdhci_ops sdhci_esdhc_ops = {
> > > .read_l = esdhc_readl,
> > > .read_w = esdhc_readw,
> > > @@ -199,6 +231,7 @@ static struct sdhci_pltfm_data sdhci_esdhc_pdata
> > > = {
> > >
> > > static int __devinit sdhci_esdhc_probe(struct platform_device
> > > *pdev) {
> > > + esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
> > > return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata); }
> > >
> > > diff --git a/drivers/mmc/host/sdhci-pltfm.c
> > > b/drivers/mmc/host/sdhci-pltfm.c index 65551a9..4dd5770 100644
> > > --- a/drivers/mmc/host/sdhci-pltfm.c
> > > +++ b/drivers/mmc/host/sdhci-pltfm.c
> > > @@ -132,8 +132,10 @@ struct sdhci_host *sdhci_pltfm_init(struct
> > platform_device *pdev,
> > > host->ops = pdata->ops;
> > > else
> > > host->ops = &sdhci_pltfm_ops;
> > > - if (pdata)
> > > + if (pdata) {
> > > host->quirks = pdata->quirks;
> > > + host->quirks2 = pdata->quirks2;
> > > + }
> > > host->irq = platform_get_irq(pdev, 0);
> > >
> > > if (!request_mem_region(iomem->start, resource_size(iomem),
> > > diff --git a/drivers/mmc/host/sdhci-pltfm.h
> > > b/drivers/mmc/host/sdhci-pltfm.h index 37e0e18..283d54a 100644
> > > --- a/drivers/mmc/host/sdhci-pltfm.h
> > > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > > @@ -18,6 +18,7 @@
> > > struct sdhci_pltfm_data {
> > > struct sdhci_ops *ops;
> > > unsigned int quirks;
> > > + unsigned int quirks2;
> > > };
> > >
> > > struct sdhci_pltfm_host {
> > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > > index 0e15c79..b0b7cad 100644
> > > --- a/drivers/mmc/host/sdhci.c
> > > +++ b/drivers/mmc/host/sdhci.c
> > > @@ -2837,6 +2837,9 @@ int sdhci_add_host(struct sdhci_host *host)
> > > if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> > > mmc->caps |= MMC_CAP_4_BIT_DATA;
> > >
> > > + if (host->quirks2 & SDHCI_QUIRK2_HOST_NO_CMD23)
> > > + mmc->caps &= ~MMC_CAP_CMD23;
> > > +
> > > if (caps[0] & SDHCI_CAN_DO_HISPD)
> > > mmc->caps |= MMC_CAP_SD_HIGHSPEED |
> > > MMC_CAP_MMC_HIGHSPEED;
> > >
> > > diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
> > > index fa8529a..1edcb4d 100644
> > > --- a/include/linux/mmc/sdhci.h
> > > +++ b/include/linux/mmc/sdhci.h
> > > @@ -91,6 +91,7 @@ struct sdhci_host {
> > > unsigned int quirks2; /* More deviations from spec. */
> > >
> > > #define SDHCI_QUIRK2_HOST_OFF_CARD_ON (1<<0)
> > > +#define SDHCI_QUIRK2_HOST_NO_CMD23 (1<<1)
> > >
> > > int irq; /* Device IRQ */
> > > void __iomem *ioaddr; /* Mapped address */
> > > --
> > > 1.7.9.5
> > >
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-mmc"
> > > in the body of a message to majordomo@vger.kernel.org More majordomo
> > > info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
2012-10-15 3:07 ` Huang Changming-R66093
@ 2012-10-23 8:41 ` Huang Changming-R66093
0 siblings, 0 replies; 7+ messages in thread
From: Huang Changming-R66093 @ 2012-10-23 8:41 UTC (permalink / raw)
To: Anton Vorontsov
Cc: linux-mmc@vger.kernel.org, Xie Shaohui-B21989, Girish K S,
Chris Ball
Anton,
could you give some comment about this patch?
Reviewed by Girish last month.
Best Regards
Jerry Huang
> -----Original Message-----
> From: Huang Changming-R66093
> Sent: Monday, October 15, 2012 11:07 AM
> To: Huang Changming-R66093; Anton Vorontsov; Chris Ball
> Cc: linux-mmc@vger.kernel.org; Xie Shaohui-B21989; Girish K S
> Subject: RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale
> SoCs
>
> Anton,
> Have you any comment about this patch?
>
> Best Regards
> Jerry Huang
>
>
> > -----Original Message-----
> > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> > owner@vger.kernel.org] On Behalf Of Huang Changming-R66093
> > Sent: Tuesday, October 09, 2012 2:24 PM
> > To: Anton Vorontsov; Chris Ball
> > Cc: linux-mmc@vger.kernel.org; Xie Shaohui-B21989; Girish K S
> > Subject: RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some
> > Freescale SoCs
> >
> > Hi, Anto and Chris
> > This version was created with the feedback from Kumar and all of you.
> > Have you any comment about this patch?
> > Could it be merged into kernel?
> >
> > Best Regards
> > Jerry Huang
> >
> > > -----Original Message-----
> > > From: Girish K S [mailto:girish.shivananjappa@linaro.org]
> > > Sent: Wednesday, September 26, 2012 9:04 PM
> > > To: Huang Changming-R66093
> > > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie
> > > Shaohui-B21989; Anton Vorontsov; Chris Ball
> > > Subject: Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some
> > > Freescale SoCs
> > >
> > > Looks good
> > > Reviewed By:- Girish K S <girish.shivananjappa@linaro.org>
> > >
> > > On 26 September 2012 15:02, <r66093@freescale.com> wrote:
> > > > From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> > > >
> > > > CMD23 causes lots of errors in kernel on some freescale SoCs
> > > > (P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used,
> > > > which is because these controllers does not support CMD23, even on
> > > > the SoCs which declares CMD23 is supported.
> > > > Therefore, we'll not use CMD23.
> > > >
> > > > Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > CC: Anton Vorontsov <cbouatmailru@gmail.com>
> > > > CC: Chris Ball <cjb@laptop.org>
> > > > ---
> > > > changes for v5:
> > > > - change the error to warning information changes for v4:
> > > > - change to detect the IP version
> > > > - don't use callback function changes for v3:
> > > > - move the limitation detect function to eSDHC file
> > > > - add the callback funtion to do this limitation detect
> > > > changes for v2:
> > > > - discard the property mode and add the processor
> > > > detection
> > > >
> > > > drivers/mmc/host/sdhci-of-esdhc.c | 33
> > > +++++++++++++++++++++++++++++++++
> > > > drivers/mmc/host/sdhci-pltfm.c | 4 +++-
> > > > drivers/mmc/host/sdhci-pltfm.h | 1 +
> > > > drivers/mmc/host/sdhci.c | 3 +++
> > > > include/linux/mmc/sdhci.h | 1 +
> > > > 5 files changed, 41 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/mmc/host/sdhci-of-esdhc.c
> > > > b/drivers/mmc/host/sdhci-of-esdhc.c
> > > > index ae5fcbf..ffc1226 100644
> > > > --- a/drivers/mmc/host/sdhci-of-esdhc.c
> > > > +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> > > > @@ -169,6 +169,38 @@ static void esdhc_of_resume(struct sdhci_host
> > > > *host) } #endif
> > > >
> > > > +static void esdhc_of_detect_limitation(struct platform_device
> *pdev,
> > > > + struct sdhci_pltfm_data *pdata) {
> > > > + void __iomem *ioaddr;
> > > > + struct resource *iomem;
> > > > + u32 vvn;
> > > > +
> > > > + iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > > + if (!iomem) {
> > > > + dev_warn(&pdev->dev, "failed to get resource\n");
> > > > + goto end;
> > > > + }
> > > > + if (resource_size(iomem) < 0x100)
> > > > + dev_warn(&pdev->dev, "Invalid iomem size!\n");
> > > > +
> > > > + ioaddr = ioremap(iomem->start, resource_size(iomem));
> > > > + if (!ioaddr) {
> > > > + dev_warn(&pdev->dev, "failed to remap registers\n");
> > > > + goto end;
> > > > + }
> > > > +
> > > > + /* P102x and P4080 has IP version VVN2.2, CMD23 is not
> > > supported */
> > > > + vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
> > > > + vvn = (vvn & SDHCI_VENDOR_VER_MASK) >>
> SDHCI_VENDOR_VER_SHIFT;
> > > > + if (vvn == VENDOR_V_22)
> > > > + pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> > > > +
> > > > + iounmap(ioaddr);
> > > > +end:
> > > > + return;
> > > > +}
> > > > +
> > > > static struct sdhci_ops sdhci_esdhc_ops = {
> > > > .read_l = esdhc_readl,
> > > > .read_w = esdhc_readw,
> > > > @@ -199,6 +231,7 @@ static struct sdhci_pltfm_data
> > > > sdhci_esdhc_pdata = {
> > > >
> > > > static int __devinit sdhci_esdhc_probe(struct platform_device
> > > > *pdev) {
> > > > + esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
> > > > return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata); }
> > > >
> > > > diff --git a/drivers/mmc/host/sdhci-pltfm.c
> > > > b/drivers/mmc/host/sdhci-pltfm.c index 65551a9..4dd5770 100644
> > > > --- a/drivers/mmc/host/sdhci-pltfm.c
> > > > +++ b/drivers/mmc/host/sdhci-pltfm.c
> > > > @@ -132,8 +132,10 @@ struct sdhci_host *sdhci_pltfm_init(struct
> > > platform_device *pdev,
> > > > host->ops = pdata->ops;
> > > > else
> > > > host->ops = &sdhci_pltfm_ops;
> > > > - if (pdata)
> > > > + if (pdata) {
> > > > host->quirks = pdata->quirks;
> > > > + host->quirks2 = pdata->quirks2;
> > > > + }
> > > > host->irq = platform_get_irq(pdev, 0);
> > > >
> > > > if (!request_mem_region(iomem->start,
> > > > resource_size(iomem), diff --git a/drivers/mmc/host/sdhci-pltfm.h
> > > > b/drivers/mmc/host/sdhci-pltfm.h index 37e0e18..283d54a 100644
> > > > --- a/drivers/mmc/host/sdhci-pltfm.h
> > > > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > > > @@ -18,6 +18,7 @@
> > > > struct sdhci_pltfm_data {
> > > > struct sdhci_ops *ops;
> > > > unsigned int quirks;
> > > > + unsigned int quirks2;
> > > > };
> > > >
> > > > struct sdhci_pltfm_host {
> > > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > > > index 0e15c79..b0b7cad 100644
> > > > --- a/drivers/mmc/host/sdhci.c
> > > > +++ b/drivers/mmc/host/sdhci.c
> > > > @@ -2837,6 +2837,9 @@ int sdhci_add_host(struct sdhci_host *host)
> > > > if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> > > > mmc->caps |= MMC_CAP_4_BIT_DATA;
> > > >
> > > > + if (host->quirks2 & SDHCI_QUIRK2_HOST_NO_CMD23)
> > > > + mmc->caps &= ~MMC_CAP_CMD23;
> > > > +
> > > > if (caps[0] & SDHCI_CAN_DO_HISPD)
> > > > mmc->caps |= MMC_CAP_SD_HIGHSPEED |
> > > > MMC_CAP_MMC_HIGHSPEED;
> > > >
> > > > diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
> > > > index fa8529a..1edcb4d 100644
> > > > --- a/include/linux/mmc/sdhci.h
> > > > +++ b/include/linux/mmc/sdhci.h
> > > > @@ -91,6 +91,7 @@ struct sdhci_host {
> > > > unsigned int quirks2; /* More deviations from spec. */
> > > >
> > > > #define SDHCI_QUIRK2_HOST_OFF_CARD_ON (1<<0)
> > > > +#define SDHCI_QUIRK2_HOST_NO_CMD23 (1<<1)
> > > >
> > > > int irq; /* Device IRQ */
> > > > void __iomem *ioaddr; /* Mapped address */
> > > > --
> > > > 1.7.9.5
> > > >
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe linux-
> mmc"
> > > > in the body of a message to majordomo@vger.kernel.org More
> > > > majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
2012-10-09 6:24 ` Huang Changming-R66093
2012-10-15 3:07 ` Huang Changming-R66093
@ 2012-10-24 8:39 ` Anton Vorontsov
2012-10-25 6:29 ` Huang Changming-R66093
1 sibling, 1 reply; 7+ messages in thread
From: Anton Vorontsov @ 2012-10-24 8:39 UTC (permalink / raw)
To: Huang Changming-R66093
Cc: Chris Ball, linux-mmc@vger.kernel.org, Xie Shaohui-B21989,
Girish K S
Sorry for the late reply, Huang.
On Tue, Oct 09, 2012 at 06:24:13AM +0000, Huang Changming-R66093 wrote:
[...]
> > > +static void esdhc_of_detect_limitation(struct platform_device *pdev,
> > > + struct sdhci_pltfm_data *pdata) {
Wrong indentation. Should be one more tab, at least (or align to opening
brace).
> > > + void __iomem *ioaddr;
> > > + struct resource *iomem;
> > > + u32 vvn;
> > > +
> > > + iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > + if (!iomem) {
> > > + dev_warn(&pdev->dev, "failed to get resource\n");
> > > + goto end;
> > > + }
> > > + if (resource_size(iomem) < 0x100)
> > > + dev_warn(&pdev->dev, "Invalid iomem size!\n");
> > > +
> > > + ioaddr = ioremap(iomem->start, resource_size(iomem));
> > > + if (!ioaddr) {
> > > + dev_warn(&pdev->dev, "failed to remap registers\n");
> > > + goto end;
> > > + }
> > > +
> > > + /* P102x and P4080 has IP version VVN2.2, CMD23 is not
> > supported */
> > > + vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
> > > + vvn = (vvn & SDHCI_VENDOR_VER_MASK) >> SDHCI_VENDOR_VER_SHIFT;
> > > + if (vvn == VENDOR_V_22)
> > > + pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> > > +
> > > + iounmap(ioaddr);
> > > +end:
> > > + return;
No need for the 'end' label.
> > > +}
> > > +
> > > static struct sdhci_ops sdhci_esdhc_ops = {
> > > .read_l = esdhc_readl,
> > > .read_w = esdhc_readw,
> > > @@ -199,6 +231,7 @@ static struct sdhci_pltfm_data sdhci_esdhc_pdata =
> > > {
> > >
> > > static int __devinit sdhci_esdhc_probe(struct platform_device *pdev)
> > > {
> > > + esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
I would rather prefer it to be in sdhci_ops (i.e. introduce
sdhci_ops->platform_init), so that way you wouldn't need to ioremap()
stuff by yourself. And make drivers/mmc/host/sdhci-pltfm.c call
platform_init after ioremap().
Then your detect_limitation() function would only need to check revision
and set additional quirks.
Thanks,
Anton.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs
2012-10-24 8:39 ` Anton Vorontsov
@ 2012-10-25 6:29 ` Huang Changming-R66093
0 siblings, 0 replies; 7+ messages in thread
From: Huang Changming-R66093 @ 2012-10-25 6:29 UTC (permalink / raw)
To: Anton Vorontsov
Cc: Chris Ball, linux-mmc@vger.kernel.org, Xie Shaohui-B21989,
Girish K S
Hi, anton,
I have resent this patch according to your suggestion.
Please review.
Thanks.
Best Regards
Jerry Huang
> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@gmail.com]
> Sent: Wednesday, October 24, 2012 4:39 PM
> To: Huang Changming-R66093
> Cc: Chris Ball; linux-mmc@vger.kernel.org; Xie Shaohui-B21989; Girish K S
> Subject: Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale
> SoCs
>
> Sorry for the late reply, Huang.
>
> On Tue, Oct 09, 2012 at 06:24:13AM +0000, Huang Changming-R66093 wrote:
> [...]
> > > > +static void esdhc_of_detect_limitation(struct platform_device
> *pdev,
> > > > + struct sdhci_pltfm_data *pdata) {
>
> Wrong indentation. Should be one more tab, at least (or align to opening
> brace).
>
> > > > + void __iomem *ioaddr;
> > > > + struct resource *iomem;
> > > > + u32 vvn;
> > > > +
> > > > + iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > > + if (!iomem) {
> > > > + dev_warn(&pdev->dev, "failed to get resource\n");
> > > > + goto end;
> > > > + }
> > > > + if (resource_size(iomem) < 0x100)
> > > > + dev_warn(&pdev->dev, "Invalid iomem size!\n");
> > > > +
> > > > + ioaddr = ioremap(iomem->start, resource_size(iomem));
> > > > + if (!ioaddr) {
> > > > + dev_warn(&pdev->dev, "failed to remap registers\n");
> > > > + goto end;
> > > > + }
> > > > +
> > > > + /* P102x and P4080 has IP version VVN2.2, CMD23 is not
> > > supported */
> > > > + vvn = in_be32(ioaddr + SDHCI_SLOT_INT_STATUS);
> > > > + vvn = (vvn & SDHCI_VENDOR_VER_MASK) >>
> SDHCI_VENDOR_VER_SHIFT;
> > > > + if (vvn == VENDOR_V_22)
> > > > + pdata->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> > > > +
> > > > + iounmap(ioaddr);
> > > > +end:
> > > > + return;
>
> No need for the 'end' label.
>
> > > > +}
> > > > +
> > > > static struct sdhci_ops sdhci_esdhc_ops = {
> > > > .read_l = esdhc_readl,
> > > > .read_w = esdhc_readw,
> > > > @@ -199,6 +231,7 @@ static struct sdhci_pltfm_data
> > > > sdhci_esdhc_pdata = {
> > > >
> > > > static int __devinit sdhci_esdhc_probe(struct platform_device
> > > > *pdev) {
> > > > + esdhc_of_detect_limitation(pdev, &sdhci_esdhc_pdata);
>
> I would rather prefer it to be in sdhci_ops (i.e. introduce sdhci_ops-
> >platform_init), so that way you wouldn't need to ioremap() stuff by
> yourself. And make drivers/mmc/host/sdhci-pltfm.c call platform_init
> after ioremap().
>
> Then your detect_limitation() function would only need to check revision
> and set additional quirks.
>
> Thanks,
> Anton.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-25 6:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 6:02 [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs r66093
2012-09-26 13:03 ` Girish K S
2012-10-09 6:24 ` Huang Changming-R66093
2012-10-15 3:07 ` Huang Changming-R66093
2012-10-23 8:41 ` Huang Changming-R66093
2012-10-24 8:39 ` Anton Vorontsov
2012-10-25 6:29 ` Huang Changming-R66093
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).