From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host Date: Tue, 30 Oct 2012 16:11:25 -0700 Message-ID: <20121030231124.GA2902@lizard> References: <1351589403-26398-1-git-send-email-yongd@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:40853 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932400Ab2J3XO0 (ORCPT ); Tue, 30 Oct 2012 19:14:26 -0400 Content-Disposition: inline In-Reply-To: <1351589403-26398-1-git-send-email-yongd@marvell.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: yongd Cc: Chris Ball , Marek Szyprowski , Shawn Guo , Wolfram Sang , Daniel Drake , Sascha Hauer , Wilson Callan , Ben Dooks , zhangfei.gao@marvell.com, kevin.liu@marvell.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote: > Sorry for my so late. And eventually these updated patches are here for your > review. Thanks in advance. > For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type, > or the host controller detection interrupts will be redundantly enabled. And its > comment is correspondingly updated. > For patch 2, broaden SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for all detection > types except S3C_SDHCI_CD_INTERNAL. Then also update the comment. > For patch 3, no update. They all look OK, but note that I did not check drivers' logic, so I hope you carefully reviewed all the drivers yourself. :) Unfortunately, you decided to go the dangerous way, instead of taking my 100%-safe approach (i.e. http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg16555.html ), which, to me, still makes more sense (of course :). Anyways, I'm not opposed either, so hopefully it works: Reviewed-by: Anton Vorontsov Thanks! Anton.