Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org,
	Chander Kashyap <chander.kashyap@linaro.org>,
	Seungwon Jeon <tgih.jun@samsung.com>
Subject: [PATCH] Revert "mmc: sdhci-s3c: Add clk_(enable/disable) in runtime  suspend/resume"
Date: Wed, 7 Nov 2012 23:57:15 +0100	[thread overview]
Message-ID: <201211072357.15572.heiko@sntech.de> (raw)

This reverts commit 2abeb5c5ded2e7f7d288058426fb0ae852adc77f, as it breaks
machines using the gpio-based card-detect option with a loop of

        mmc0: Timeout waiting for hardware interrupt.
        mmc0: Internal clock never stabilised.
        mmc0: Timeout waiting for hardware interrupt.
        mmc0: Internal clock never stabilised.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
This is of course meant for 3.7-rc

 drivers/mmc/host/sdhci-s3c.c |   29 ++---------------------------
 1 file changed, 2 insertions(+), 27 deletions(-)

diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 2903949..e019672 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -637,9 +637,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
 		goto err_no_busclks;
 	}
 
-#ifndef CONFIG_PM_RUNTIME
 	clk_enable(sc->clk_bus[sc->cur_clk]);
-#endif
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	host->ioaddr = devm_request_and_ioremap(&pdev->dev, res);
@@ -746,15 +744,10 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
 	    gpio_is_valid(pdata->ext_cd_gpio))
 		sdhci_s3c_setup_card_detect_gpio(sc);
 
-#ifdef CONFIG_PM_RUNTIME
-	clk_disable(sc->clk_io);
-#endif
 	return 0;
 
  err_req_regs:
-#ifndef CONFIG_PM_RUNTIME
 	clk_disable(sc->clk_bus[sc->cur_clk]);
-#endif
 	for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
 		if (sc->clk_bus[ptr]) {
 			clk_put(sc->clk_bus[ptr]);
@@ -793,17 +786,12 @@ static int __devexit sdhci_s3c_remove(struct platform_device *pdev)
 	if (gpio_is_valid(sc->ext_cd_gpio))
 		gpio_free(sc->ext_cd_gpio);
 
-#ifdef CONFIG_PM_RUNTIME
-	clk_enable(sc->clk_io);
-#endif
 	sdhci_remove_host(host, 1);
 
 	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 
-#ifndef CONFIG_PM_RUNTIME
 	clk_disable(sc->clk_bus[sc->cur_clk]);
-#endif
 	for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
 		if (sc->clk_bus[ptr]) {
 			clk_put(sc->clk_bus[ptr]);
@@ -843,28 +831,15 @@ static int sdhci_s3c_resume(struct device *dev)
 static int sdhci_s3c_runtime_suspend(struct device *dev)
 {
 	struct sdhci_host *host = dev_get_drvdata(dev);
-	struct sdhci_s3c *ourhost = to_s3c(host);
-	struct clk *busclk = ourhost->clk_io;
-	int ret;
-
-	ret = sdhci_runtime_suspend_host(host);
 
-	clk_disable(ourhost->clk_bus[ourhost->cur_clk]);
-	clk_disable(busclk);
-	return ret;
+	return sdhci_runtime_suspend_host(host);
 }
 
 static int sdhci_s3c_runtime_resume(struct device *dev)
 {
 	struct sdhci_host *host = dev_get_drvdata(dev);
-	struct sdhci_s3c *ourhost = to_s3c(host);
-	struct clk *busclk = ourhost->clk_io;
-	int ret;
 
-	clk_enable(busclk);
-	clk_enable(ourhost->clk_bus[ourhost->cur_clk]);
-	ret = sdhci_runtime_resume_host(host);
-	return ret;
+	return sdhci_runtime_resume_host(host);
 }
 #endif
 
-- 
1.7.10.4


             reply	other threads:[~2012-11-07 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-07 22:57 Heiko Stübner [this message]
2012-11-17 21:14 ` [PATCH] Revert "mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume" Chris Ball
2012-11-18 18:50   ` [PATCH] mmc: sdhci-s3c: fix missing clock for gpio card-detect Heiko Stübner
2012-11-18 19:05     ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201211072357.15572.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=chander.kashyap@linaro.org \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox