From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kevin Liu <keyuan.liu@gmail.com>
Cc: m.szyprowski@samsung.com, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
kyungmin.park@samsung.com, lrg@ti.com,
Philip Rakity <prakity@nvidia.com>
Subject: Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators
Date: Wed, 14 Nov 2012 17:41:07 +0900 [thread overview]
Message-ID: <20121114084105.GG7407@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CADz5_gLb5ZRHLZHw1sDDWzu4QgOR7JXnaRMEXxETNzVsu1Wq1A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On Wed, Nov 14, 2012 at 04:36:28PM +0800, Kevin Liu wrote:
> 2012/11/14 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > Should this be regulator_set_voltage_tol()? Otherwise it'd be good to
> > explain where the numbers come from.
> In SD physical layer spec 3.01 chapter 6.6.1, the threshold level for
> voltage range is defined as below:
> Vdd(min) = 2.7V while Vdd(max) = 3.6V.
> The card should work within the voltage range.
> If you are afraid the voltage value is too aggressive, maybe we can
> use regulator_set_voltage_tol() to set a smaller range.
> But which range should be reasonable?
The above makes total sense - thanks! I just wasn't aware that the
range was specified in this fashion in the spec. Might be worth a
comment in the code if you need to respin.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-14 8:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <25B60CDC2F704E4E9D88FFD52780CB4C060FBEA29A@SC-VEXCH1.marvell.com>
2012-11-14 7:11 ` FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators Kevin Liu
2012-11-14 7:28 ` Mark Brown
2012-11-14 8:36 ` Kevin Liu
2012-11-14 8:41 ` Mark Brown [this message]
2012-11-14 8:57 ` Kevin Liu
2012-11-14 9:08 ` Philip Rakity
2012-11-14 12:05 ` Kevin Liu
2012-11-20 7:44 ` FW: " Marek Szyprowski
2012-11-20 8:59 ` Kevin Liu
2012-11-20 10:16 ` Marek Szyprowski
2012-11-20 11:36 ` Kevin Liu
2012-11-20 13:12 ` Marek Szyprowski
2012-11-20 13:27 ` Chris Ball
2012-11-20 14:14 ` Kevin Liu
2012-11-20 15:02 ` Marek Szyprowski
2012-11-20 15:24 ` Kevin Liu
2012-11-30 16:48 ` Chris Ball
2012-12-04 14:07 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114084105.GG7407@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=keyuan.liu@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
--cc=prakity@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).