From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: Chris Ball <cjb@laptop.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card
Date: Sun, 18 Nov 2012 18:58:16 -0800 [thread overview]
Message-ID: <20121119025816.GB5165@lizard> (raw)
In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C224F8F@039-SN1MPN1-004.039d.mgd.msft.net>
On Mon, Nov 19, 2012 at 02:50:18AM +0000, Huang Changming-R66093 wrote:
[...]
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index
> > f05a377..cc9c8a6 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(struct mmc_host *mmc)
> > return ret;
> > }
> >
> > +/* Return values for the sdjco_get_cd callback:
> > + * 0 for a absent card
> > + * 1 for a present card
> > + * -ENOSYS when not supported (equal to NULL callback)
> > + */
Incorrect style.
> > +static int sdhci_get_cd(struct mmc_host *mmc) {
ditto
> > + struct sdhci_host *host = mmc_priv(mmc);
> > + unsigned long flags;
> > + int present = -ENOSYS;
if (!host->ops->get_cd)
return -ENOSYS;
...
...
Otherwise, it looks good.
Reviewed-by: Anton Vorontsov <cbouatmailru@gmail.com>
next prev parent reply other threads:[~2012-11-19 3:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 8:12 [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() r66093
2012-10-30 8:12 ` [PATCH 2/4 v4] MMC/SD: Add callback function to detect card r66093
2012-10-30 8:12 ` [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card r66093
2012-10-30 8:12 ` [PATCH 4/4 v4] ESDHC: add callback esdhc_of_get_cd to detect card r66093
2012-11-19 2:50 ` Huang Changming-R66093
2012-11-19 2:54 ` Anton Vorontsov
2012-11-19 2:50 ` [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card Huang Changming-R66093
2012-11-19 2:58 ` Anton Vorontsov [this message]
2012-11-19 3:15 ` Huang Changming-R66093
2012-11-19 3:31 ` Anton Vorontsov
2012-11-19 3:38 ` Huang Changming-R66093
2012-10-30 11:34 ` [PATCH 2/4 v4] MMC/SD: Add callback function to detect card Girish K S
2012-10-31 2:23 ` Huang Changming-R66093
2012-10-31 4:29 ` Jaehoon Chung
2012-10-31 5:52 ` Huang Changming-R66093
2012-11-01 15:57 ` Johan Rudholm
2012-11-02 1:37 ` Huang Changming-R66093
2012-11-02 10:33 ` Johan Rudholm
2012-11-05 3:17 ` Huang Changming-R66093
2012-11-05 14:07 ` Johan Rudholm
2012-11-06 1:55 ` Huang Changming-R66093
2012-11-06 1:55 ` Huang Changming-R66093
2012-11-13 7:50 ` Huang Changming-R66093
2012-11-19 2:48 ` Huang Changming-R66093
2012-11-19 3:05 ` Anton Vorontsov
2012-11-19 3:11 ` Huang Changming-R66093
2012-10-30 23:08 ` [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() Ulf Hansson
2012-10-31 2:23 ` Huang Changming-R66093
2012-10-31 4:21 ` Jaehoon Chung
-- strict thread matches above, loose matches on Subject: below --
2011-12-14 2:18 [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card r66093
2011-12-14 4:51 ` Philip Rakity
2011-12-15 2:32 ` Huang Changming-R66093
2011-12-15 6:41 ` Philip Rakity
2011-12-15 6:56 ` Huang Changming-R66093
2011-12-15 10:04 ` Jaehoon Chung
2011-12-16 3:25 ` Huang Changming-R66093
2011-12-16 4:05 ` Jaehoon Chung
2011-12-16 4:33 ` Huang Changming-R66093
2012-01-13 2:25 ` Huang Changming-R66093
2012-01-13 3:26 ` Aaron Lu
2012-01-13 4:50 ` Huang Changming-R66093
2012-01-13 6:20 ` Aaron Lu
2012-01-13 6:44 ` Huang Changming-R66093
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119025816.GB5165@lizard \
--to=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).