From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card Date: Sun, 18 Nov 2012 18:58:16 -0800 Message-ID: <20121119025816.GB5165@lizard> References: <1351584769-16662-1-git-send-email-r66093@freescale.com> <1351584769-16662-2-git-send-email-r66093@freescale.com> <1351584769-16662-3-git-send-email-r66093@freescale.com> <110EED8CC96DFC488B7E717A2027A27C224F8F@039-SN1MPN1-004.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:61715 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816Ab2KSDB0 (ORCPT ); Sun, 18 Nov 2012 22:01:26 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so3124519pbc.19 for ; Sun, 18 Nov 2012 19:01:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C224F8F@039-SN1MPN1-004.039d.mgd.msft.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Huang Changming-R66093 Cc: Chris Ball , "linux-mmc@vger.kernel.org" On Mon, Nov 19, 2012 at 02:50:18AM +0000, Huang Changming-R66093 wrote: [...] > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index > > f05a377..cc9c8a6 100644 > > --- a/drivers/mmc/host/sdhci.c > > +++ b/drivers/mmc/host/sdhci.c > > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(struct mmc_host *mmc) > > return ret; > > } > > > > +/* Return values for the sdjco_get_cd callback: > > + * 0 for a absent card > > + * 1 for a present card > > + * -ENOSYS when not supported (equal to NULL callback) > > + */ Incorrect style. > > +static int sdhci_get_cd(struct mmc_host *mmc) { ditto > > + struct sdhci_host *host = mmc_priv(mmc); > > + unsigned long flags; > > + int present = -ENOSYS; if (!host->ops->get_cd) return -ENOSYS; ... ... Otherwise, it looks good. Reviewed-by: Anton Vorontsov