Re: [PATCH 2/2] Powerpc/eSDHC: Add limit to data and erase timeout value calculation

[Anton Vorontsov <cbouatmailru@gmail.com>]

On Mon, Nov 19, 2012 at 11:38:29AM +0800, Haijun Zhang wrote:
> Some cards apply too larg timeout value for host to response,
> So limit the maximum data transfer timeout value and maximum erase
> timeout value to aviod timeout issue.
> 
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>

Ditto about the sign-off, it's inappropriate in this case.

[...]
> @@ -721,6 +722,10 @@ void mmc_set_data_timeout(struct mmc_data *data, const struct mmc_card *card)
>  				data->timeout_ns =  100000000;	/* 100ms */
>  		}
>  	}
> +
> +	if (host->max_discard_to &&
> +		host->max_discard_to < div_u64(data->timeout_ns, 1000000))

Still wrong indentation.

> +		data->timeout_ns = (u64)host->max_discard_to * 1000000;
>  }
>  EXPORT_SYMBOL(mmc_set_data_timeout);