* [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
@ 2012-11-21 9:22 Eric Miao
2012-11-21 9:43 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Eric Miao @ 2012-11-21 9:22 UTC (permalink / raw)
To: Mark Brown; +Cc: Philip Rakity, Philip Rakity, linux-mmc@vger.kernel.org
Hi Mark,
Looks to be a simple omission there. Patch is from Philip Rakity, I
just did review and by-passing here.
>From d015139ac621e10d5d9c0d3e427e9517b08fe772 Mon Sep 17 00:00:00 2001
From: Philip Rakity <prakity@nvidia.com>
Date: Tue, 20 Nov 2012 18:07:41 +0100
Subject: [PATCH] regulator: add missing prototype for
regulator_is_supported_voltage
avoids needs for CONFIG_REGULATOR in sdhci.c
Signed-off-by: Philip Rakity <prakity@nvidia.com>
Reviewed-by: Eric Miao <eric.y.miao@gmail.com>
---
include/linux/regulator/consumer.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/linux/regulator/consumer.h
b/include/linux/regulator/consumer.h
index c43cd35..4e3ec91 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -358,6 +358,10 @@ static inline void regulator_set_drvdata(struct
regulator *regulator,
{
}
+static inline int regulator_count_voltages(struct regulator *regulator)
+{
+ return 0;
+}
#endif
static inline int regulator_set_voltage_tol(struct regulator *regulator,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
2012-11-21 9:22 [PATCH] regulator: add missing prototype for regulator_is_supported_voltage Eric Miao
@ 2012-11-21 9:43 ` Mark Brown
2012-11-21 9:45 ` Eric Miao
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-11-21 9:43 UTC (permalink / raw)
To: Eric Miao; +Cc: Philip Rakity, Philip Rakity, linux-mmc@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
On Wed, Nov 21, 2012 at 05:22:02PM +0800, Eric Miao wrote:
> +static inline int regulator_count_voltages(struct regulator *regulator)
> +{
> + return 0;
> +}
Looks like your mailer has mangled everything so this won't apply.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
2012-11-21 9:43 ` Mark Brown
@ 2012-11-21 9:45 ` Eric Miao
2012-11-21 10:05 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Eric Miao @ 2012-11-21 9:45 UTC (permalink / raw)
To: Mark Brown; +Cc: Philip Rakity, Philip Rakity, linux-mmc@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
git-send-email stopped working so I have to use the web interface.
Could you help
try the attached one?
On Wed, Nov 21, 2012 at 5:43 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Nov 21, 2012 at 05:22:02PM +0800, Eric Miao wrote:
>
>> +static inline int regulator_count_voltages(struct regulator *regulator)
>> +{
>> + return 0;
>> +}
>
> Looks like your mailer has mangled everything so this won't apply.
[-- Attachment #2: 0001-regulator-add-missing-prototype-for-regulator_is_sup.patch --]
[-- Type: application/octet-stream, Size: 966 bytes --]
From d015139ac621e10d5d9c0d3e427e9517b08fe772 Mon Sep 17 00:00:00 2001
From: Philip Rakity <prakity@nvidia.com>
Date: Tue, 20 Nov 2012 18:07:41 +0100
Subject: [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
avoids needs for CONFIG_REGULATOR in sdhci.c
Signed-off-by: Philip Rakity <prakity@nvidia.com>
Reviewed-by: Eric Miao <eric.y.miao@gmail.com>
---
include/linux/regulator/consumer.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index c43cd35..4e3ec91 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -358,6 +358,10 @@ static inline void regulator_set_drvdata(struct regulator *regulator,
{
}
+static inline int regulator_count_voltages(struct regulator *regulator)
+{
+ return 0;
+}
#endif
static inline int regulator_set_voltage_tol(struct regulator *regulator,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
2012-11-21 9:45 ` Eric Miao
@ 2012-11-21 10:05 ` Mark Brown
2012-11-21 10:06 ` Eric Miao
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-11-21 10:05 UTC (permalink / raw)
To: Eric Miao; +Cc: Philip Rakity, Philip Rakity, linux-mmc@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Wed, Nov 21, 2012 at 05:45:57PM +0800, Eric Miao wrote:
> git-send-email stopped working so I have to use the web interface.
> Could you help
> try the attached one?
OK. I take it's OK to add your signoff as well (you should always add
this for patches you forward)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
2012-11-21 10:05 ` Mark Brown
@ 2012-11-21 10:06 ` Eric Miao
2012-11-21 10:09 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Eric Miao @ 2012-11-21 10:06 UTC (permalink / raw)
To: Mark Brown; +Cc: Philip Rakity, Philip Rakity, linux-mmc@vger.kernel.org
On Wed, Nov 21, 2012 at 6:05 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Nov 21, 2012 at 05:45:57PM +0800, Eric Miao wrote:
>> git-send-email stopped working so I have to use the web interface.
>> Could you help
>> try the attached one?
>
> OK. I take it's OK to add your signoff as well (you should always add
> this for patches you forward)?
Yep, that's fine.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: add missing prototype for regulator_is_supported_voltage
2012-11-21 10:06 ` Eric Miao
@ 2012-11-21 10:09 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-11-21 10:09 UTC (permalink / raw)
To: Eric Miao; +Cc: Philip Rakity, Philip Rakity, linux-mmc@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 98 bytes --]
On Wed, Nov 21, 2012 at 06:06:12PM +0800, Eric Miao wrote:
> Yep, that's fine.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-21 10:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 9:22 [PATCH] regulator: add missing prototype for regulator_is_supported_voltage Eric Miao
2012-11-21 9:43 ` Mark Brown
2012-11-21 9:45 ` Eric Miao
2012-11-21 10:05 ` Mark Brown
2012-11-21 10:06 ` Eric Miao
2012-11-21 10:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox