From: Fengguang Wu <fengguang.wu@intel.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: Zhang Haijun-B42677 <B42677@freescale.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>
Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'
Date: Mon, 26 Nov 2012 14:02:31 +0800 [thread overview]
Message-ID: <20121126060231.GA24503@localhost> (raw)
In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C235D56@039-SN1MPN1-003.039d.mgd.msft.net>
On Mon, Nov 26, 2012 at 05:54:33AM +0000, Huang Changming-R66093 wrote:
> Hi, Robot
> I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc tree.
> Could you point out which file use it?
>
> This patch just use the 'div_u64' to calculate the timeout in order to avoid overflow.
Hi! This is confirmed to fix the problem:
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 48ad361..daf0636 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -921,7 +921,7 @@ static inline void set_data_timeout(struct mmc_omap_host *host, struct mmc_reque
u16 reg;
cycle_ns = 1000000000 / host->current_slot->fclk_freq;
- timeout = req->data->timeout_ns / cycle_ns;
+ timeout = div_u64(req->data->timeout_ns, cycle_ns);
timeout += req->data->timeout_clks;
/* Check if we need to use timeout multiplier register */
next prev parent reply other threads:[~2012-11-26 6:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 23:13 [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' kbuild test robot
2012-11-25 23:51 ` Chris Ball
2012-11-26 4:11 ` Zhang Haijun-B42677
2012-11-26 10:02 ` Zhang Haijun-B42677
2012-12-14 2:52 ` Zhang Haijun-B42677
2013-01-15 2:03 ` Zhang Haijun-B42677
2012-11-26 5:54 ` Huang Changming-R66093
2012-11-26 6:02 ` Fengguang Wu [this message]
2012-11-26 6:12 ` Zhang Haijun-B42677
2012-11-26 6:21 ` Fengguang Wu
2012-11-26 7:23 ` Zhang Haijun-B42677
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126060231.GA24503@localhost \
--to=fengguang.wu@intel.com \
--cc=B42677@freescale.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox