Re: [PATCH] Powerpc eSDHC: Convert the cmd_timeou_ms to u64 to avoid overflow

[Anton Vorontsov <cbouatmailru@gmail.com>]

On Mon, Nov 26, 2012 at 04:35:58PM +0800, Haijun Zhang wrote:
> Convert the cmd_timeou_ms to u64 to avoid overflow
> 
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>

Reviewed-by: Anton Vorontsov <cbouatmailru@gmail.com>

But I think you should merge the two patches...

Thanks,

> CC: Chris Ball <cjb@laptop.org>
> ---
>  drivers/mmc/card/block.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 21056b9..51903de 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -469,7 +469,8 @@ static int mmc_blk_ioctl_cmd(struct block_device *bdev,
>  			 *     mrq.data = NULL;
>  			 *     cmd.cmd_timeout = idata->ic.cmd_timeout_ms;
>  			 */
> -			data.timeout_ns = idata->ic.cmd_timeout_ms * 1000000;
> +			data.timeout_ns = (u64)idata->ic.cmd_timeout_ms *
> +						1000000;
>  		}
>  
>  		mrq.data = &data;
> -- 
> 1.7.0.4