From: Felipe Balbi <balbi@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: balbi@ti.com, Peter Ujfalusi <peter.ujfalusi@ti.com>,
Luciano Coelho <coelho@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
svenkatr@ti.com, linux-omap@vger.kernel.org,
linux-mmc@vger.kernel.org, cjb@laptop.org, lrg@ti.com,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
r.sricharan@ti.com
Subject: Re: 32kHz clock removal causes problems omap_hsmmc
Date: Wed, 19 Dec 2012 15:54:28 +0200 [thread overview]
Message-ID: <20121219135428.GD17993@arwen.pp.htv.fi> (raw)
In-Reply-To: <50D1C652.3050607@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2088 bytes --]
Hi,
On Wed, Dec 19, 2012 at 02:51:14PM +0100, Benoit Cousson wrote:
> On 12/19/2012 02:01 PM, Felipe Balbi wrote:
> > Hi,
> >
> > +Sricharan who commited that
> >
> > On Wed, Dec 19, 2012 at 11:56:20AM +0100, Peter Ujfalusi wrote:
> >> On 12/19/2012 11:45 AM, Luciano Coelho wrote:
> >>>> Well, we still haven't got the foggiest idea what the actual problem is
> >>>> beyond that it's probably related to the 32kHz clock in some way (unless
> >>>> it was one of the other reverts that coincidentally made a difference,
> >>>> but we don't know what they were) so it's unlikely that just randomly
> >>>> implementing clock support is going to fix anything immediately here.
> >>>
> >>> This is exactly what I had to revert (as I mentioned in the other email,
> >>> I had to revert the other patches otherwise compilation would break):
> >>>
> >>> 0e8e5c34 "regulator: twl: Remove references to 32kHz clock from DT bindings"
> >>> e76ab829 "regulator: twl: Remove references to the twl4030 regulator"
> >>> 029dd3ce "regulator: twl: Remove another unused variable warning"
> >>
> >> Yeah. 32k clock is not provided by twl.
> >>
> >> As I said I need to take a look at CCF to see if it already there. If it is
> >> clock driver + mapping + patch for wl12xx should fix the issue you are facing.
> >>
> >>> Let me know if you need more info.
> >>
> >> BTW: have you happened to ubdate u-boot recently? There is a nice easter egg
> >> added there:
> >> f3f98bb ARM: OMAP4/5: Do not configure non essential pads, clocks, dplls.
> >>
> >> Which means that _essential_ clocks and pads are no longer configured.
> >
> > anything essential you can list ?
>
> Yeah, that u-boot version is just unusable at all with any mainline
> kernel, since we are still missing pads conf for every drivers.
>
> Regarding the 32k clock, I noticed as well that the OMAP4460 panda
> u-boot is the only one to enable it at boot time, and thus this is the
> only board that can probe the wilink chip properly as of today.
hah, way to cause regression
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-19 13:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:31 32kHz clock removal causes problems omap_hsmmc Luciano Coelho
2012-12-18 9:54 ` Felipe Balbi
2012-12-19 9:45 ` Mark Brown
2012-12-19 10:00 ` Peter Ujfalusi
2012-12-19 10:09 ` Mark Brown
2012-12-19 10:18 ` Peter Ujfalusi
2012-12-19 10:32 ` Mark Brown
2012-12-19 10:45 ` Luciano Coelho
2012-12-19 10:56 ` Peter Ujfalusi
2012-12-19 11:00 ` Peter Ujfalusi
2012-12-19 11:02 ` Mark Brown
2012-12-19 11:07 ` Luciano Coelho
2012-12-19 13:01 ` Felipe Balbi
2012-12-19 13:51 ` Benoit Cousson
2012-12-19 13:54 ` Felipe Balbi [this message]
2012-12-19 13:58 ` Mark Brown
2012-12-19 13:58 ` Luciano Coelho
2012-12-19 14:04 ` Benoit Cousson
2012-12-19 18:06 ` R Sricharan
2012-12-19 14:31 ` Peter Ujfalusi
2012-12-19 16:28 ` Tony Lindgren
2012-12-19 10:01 ` Luciano Coelho
2012-12-19 10:28 ` Mark Brown
2012-12-19 10:42 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219135428.GD17993@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=coelho@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=r.sricharan@ti.com \
--cc=svenkatr@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox