From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant Date: Fri, 21 Dec 2012 10:39:55 +0000 Message-ID: <20121221103955.GH14363@n2100.arm.linux.org.uk> References: <20121121165048.GO3290@n2100.arm.linux.org.uk> <20121122173708.GJ5764@n2100.arm.linux.org.uk> <50B34270.7070403@stericsson.com> <20121126102712.GC19440@n2100.arm.linux.org.uk> <50B349D3.2050806@stericsson.com> <20121128171221.GF19440@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:35420 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594Ab2LUKmK (ORCPT ); Fri, 21 Dec 2012 05:42:10 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: Per Forlin , Ulf HANSSON , "linux-mmc@vger.kernel.org" , Chris Ball , "linux-arm-kernel@lists.infradead.org" , Linus Walleij On Fri, Dec 21, 2012 at 11:36:32AM +0100, Ulf Hansson wrote: > Just wanted to conclude on the way forward. Should we fixup pio_write > according to how pio_read has been fixed, or should we adapt the check > for misaligned buffers to what Per proposed? > What do you prefer Russell? It's really silly to have pio_read doing something that pio_write doesn't do - they should have the same behaviour except for the differing data flow direction.