From: Borislav Petkov <bp@alien8.de>
To: wei_wang@realsil.com.cn
Cc: cjb@laptop.org, sameo@linux.intel.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, oakad@yahoo.com
Subject: Re: [PATCH 2/7] MFD:rtsx: Remove redundant code
Date: Mon, 24 Dec 2012 11:11:34 +0100 [thread overview]
Message-ID: <20121224101134.GB6702@liondog.tnic> (raw)
In-Reply-To: <19e2c741f89b80b9d1640ff00902b1cc3f76a171.1356319097.git.wei_wang@realsil.com.cn>
On Mon, Dec 24, 2012 at 02:03:24PM +0800, wei_wang@realsil.com.cn wrote:
> From: Wei WANG <wei_wang@realsil.com.cn>
>
> Signed-off-by: Wei WANG <wei_wang@realsil.com.cn>
> ---
> drivers/mfd/rtsx_pcr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 3a44efa..fa2c2bc 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -325,7 +325,6 @@ static void rtsx_pci_add_sg_tbl(struct rtsx_pcr *pcr,
> val = ((u64)addr << 32) | ((u64)len << 12) | option;
>
> put_unaligned_le64(val, ptr);
> - ptr++;
> pcr->sgi++;
Hmm, one has to look at the whole function to understand that the ptr++
statement is actually useless. A sentence or two as a the commit message
wouldn't hurt, IMHO.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2012-12-24 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 6:03 [PATCH 0/7] rtsx patchset for MFD and MMC tree wei_wang
2012-12-24 6:03 ` [PATCH 1/7] MFD:rtsx: Fix typo in comment wei_wang
2012-12-24 6:03 ` [PATCH 2/7] MFD:rtsx: Remove redundant code wei_wang
2012-12-24 10:11 ` Borislav Petkov [this message]
2012-12-24 6:03 ` [PATCH 3/7] MFD:rtsx: Declare that the DMA address limitation is 32bit explicitly wei_wang
2012-12-24 13:08 ` Borislav Petkov
2012-12-24 6:03 ` [PATCH 4/7] MFD:rtsx: Add callback function switch_output_voltage wei_wang
2012-12-24 6:03 ` [PATCH 5/7] MMC:rtsx: Using callback function to switch output voltage wei_wang
2012-12-24 6:03 ` [PATCH 6/7] MFD:rtsx: Add callback function conv_clk_and_div_n wei_wang
2012-12-24 6:03 ` [PATCH 7/7] MFD:rtsx: Fix checkpatch warning wei_wang
2012-12-24 16:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224101134.GB6702@liondog.tnic \
--to=bp@alien8.de \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox