From: Borislav Petkov <bp@alien8.de>
To: wei_wang@realsil.com.cn
Cc: cjb@laptop.org, sameo@linux.intel.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, oakad@yahoo.com
Subject: Re: [PATCH v2 3/8] MFD:rtsx: Declare that the DMA address limitation is 32bit explicitly
Date: Tue, 25 Dec 2012 12:13:41 +0100 [thread overview]
Message-ID: <20121225111341.GE7692@liondog.tnic> (raw)
In-Reply-To: <7ba22b7e0e0be5a353cdfcfefbeff03a5be973c0.1356403281.git.wei_wang@realsil.com.cn>
On Tue, Dec 25, 2012 at 10:43:09AM +0800, wei_wang@realsil.com.cn wrote:
> From: Wei WANG <wei_wang@realsil.com.cn>
>
> Signed-off-by: Wei WANG <wei_wang@realsil.com.cn>
This one is still missing a commit message. You might want to write some
blubber about the hardware supporting only 32-bit DMA or whatever the
real reason is.
Also, with the whole patchset, please don't send it the very next day
but do wait a couple of days to collect all feedback from people -
especially now I'd wait even longer since everyone except you and me are
away :) - and then resend it after incorporating all feedback.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2012-12-25 11:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 2:42 [PATCH v2 0/8] rtsx patchset for MFD and MMC tree wei_wang
2012-12-25 2:42 ` [PATCH v2 1/8] MFD:rtsx: Fix typo in comment wei_wang
2012-12-25 2:43 ` [PATCH v2 2/8] MFD:rtsx: Remove redundant code wei_wang
2012-12-25 11:11 ` Borislav Petkov
2012-12-25 2:43 ` [PATCH v2 3/8] MFD:rtsx: Declare that the DMA address limitation is 32bit explicitly wei_wang
2012-12-25 11:13 ` Borislav Petkov [this message]
2012-12-25 2:43 ` [PATCH v2 4/8] MFD:rtsx: Add callback function switch_output_voltage wei_wang
2012-12-25 2:43 ` [PATCH v2 5/8] MMC:rtsx: Using callback function to switch output voltage wei_wang
2012-12-25 2:43 ` [PATCH v2 6/8] MFD:rtsx: Add callback function conv_clk_and_div_n wei_wang
2012-12-25 2:43 ` [PATCH v2 7/8] MFD:rtsx: Fix checkpatch warning wei_wang
2012-12-25 2:43 ` [PATCH v2 8/8] MFD:rtsx: Use macro defines to replace some variables wei_wang
2012-12-25 11:14 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121225111341.GE7692@liondog.tnic \
--to=bp@alien8.de \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox