From: Dan Carpenter <dan.carpenter@oracle.com>
To: wwang <wei_wang@realsil.com.cn>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"oakad@yahoo.com" <oakad@yahoo.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"bp@alien8.de" <bp@alien8.de>, "cjb@laptop.org" <cjb@laptop.org>
Subject: Re: [PATCH v3 3/8] MFD:rtsx: Declare that the DMA address limitationis32bit explicitly
Date: Fri, 4 Jan 2013 08:50:31 +0300 [thread overview]
Message-ID: <20130104055031.GQ7247@mwanda> (raw)
In-Reply-To: <50E6427E.1050809@realsil.com.cn>
On Fri, Jan 04, 2013 at 10:46:22AM +0800, wwang wrote:
> 于 2013年01月03日 20:25, Dan Carpenter 写道:
> > On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_wang@realsil.com.cn wrote:
> >> From: Wei WANG <wei_wang@realsil.com.cn>
> >>
> >> Realtek PCIe card reader only supports 32bit DMA
> >>
> > Is this a bugfix? If so what does the bug look like?
> >
> > regards,
> > dan carpenter
> >
> Hi Dan:
>
> No, this is not a bugfix. In default, the kernel will allocate 32bit
> address for DMA. This declaration can improve the readability.
>
Ah ok. Really none of the things I mentioned were stuff that
prevented the patch from being merged or couldn't be fixed in follow
on patches.
The thing is that the commit message should always say why a patch
is needed.
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-04 5:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 2:41 [PATCH v3 0/8] rtsx patchset for MFD and MMC tree wei_wang
2012-12-28 2:41 ` [PATCH v3 1/8] MFD:rtsx: Fix typo in comment wei_wang
2012-12-28 2:41 ` [PATCH v3 2/8] MFD:rtsx: Remove redundant code wei_wang
2012-12-28 2:41 ` [PATCH v3 3/8] MFD:rtsx: Declare that the DMA address limitation is 32bit explicitly wei_wang
2013-01-03 12:25 ` Dan Carpenter
2013-01-04 2:46 ` [PATCH v3 3/8] MFD:rtsx: Declare that the DMA address limitationis32bit explicitly wwang
2013-01-04 5:50 ` Dan Carpenter [this message]
2012-12-28 2:41 ` [PATCH v3 4/8] MFD:rtsx: Add callback function switch_output_voltage wei_wang
2012-12-28 2:41 ` [PATCH v3 5/8] MMC:rtsx: Using callback function to switch output voltage wei_wang
2012-12-28 2:41 ` [PATCH v3 6/8] MFD:rtsx: Add callback function conv_clk_and_div_n wei_wang
2013-01-03 12:42 ` Dan Carpenter
2012-12-28 2:41 ` [PATCH v3 7/8] MFD:rtsx: Fix checkpatch warning wei_wang
2013-01-03 12:44 ` Dan Carpenter
2012-12-28 2:41 ` [PATCH v3 8/8] MFD:rtsx: Use macro defines to replace some variables wei_wang
2013-01-03 14:11 ` [PATCH v3 0/8] rtsx patchset for MFD and MMC tree Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130104055031.GQ7247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).