From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v2] mmc: mvsdio: Replace IS_ERR_OR_NULL() with IS_ERR() Date: Sun, 13 Jan 2013 15:43:48 -0500 Message-ID: <20130113204348.GR13433@titan.lakedaemon.net> References: <20130111004323.GA12257@schnuecks.de> <1357889273-11553-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:47992 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755511Ab3AMUny (ORCPT ); Sun, 13 Jan 2013 15:43:54 -0500 Content-Disposition: inline In-Reply-To: <1357889273-11553-1-git-send-email-andrew@lunn.ch> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Andrew Lunn Cc: Thomas Petazzoni , gmbnomis@gmail.com, linux-mmc@vger.kernel.org, cjb@laptop.org, linux ARM On Fri, Jan 11, 2013 at 08:27:52AM +0100, Andrew Lunn wrote: > A NULL is a valid clk cookie, so we should not be tested with > IS_ERR_OR_NULL(). Replace it with IS_ERR(). > > Signed-off-by: Andrew Lunn > --- > > This patch depends on Thomas Petazzoni DT patches for mvsdio, which changed > the order of resource allocation etc. grrr, I'm seeing fixes depending on features :( Any way to avoid that? In light of Russell's comments, shall I wait for a v3? All of Thomas' mvsdio work is now waiting on this. I'd like to get that in as early as possible. thx, Jason.