From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCH v2 2/3] dma: edma: add device_channel_caps() support Date: Mon, 21 Jan 2013 13:29:21 -0500 Message-ID: <20130121182921.GF10020@beef> References: <1357844826-30746-1-git-send-email-mporter@ti.com> <1357844826-30746-3-git-send-email-mporter@ti.com> <7bca07cce8884261b9828946dff5a076@DFLE72.ent.ti.com> <20130120165108.GE21407@beef> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qc0-f176.google.com ([209.85.216.176]:33103 "EHLO mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782Ab3AUS3X (ORCPT ); Mon, 21 Jan 2013 13:29:23 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Vinod Koul Cc: Dan Williams , Chris Ball , Grant Likely , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux MMC List On Mon, Jan 21, 2013 at 03:16:32AM +0000, Vinod Koul wrote: > On Sun, Jan 20, 2013 at 11:51:08AM -0500, Matt Porter wrote: > > The explanation in the cover letter mentions that dmaengine_slave_config() is > > required to be called prior to dmaengine_get_channel_caps(). If we > > switch to the alternative API, then that would go away including the > > dependency on direction. > Nope you got that wrong! :) Yes, dropped the ball there, should have been for the api to make sense as implemented: 1. Allocate a DMA slave channel 2. Set slave and controller specific parameters 2a. [Optionally] Get channel capabilities 3. Get a descriptor for transaction 4. Submit the transaction 5. Issue pending requests and wait for callback notification FWIW, the implementation example in the davinci mmc client driver shows proper use as in the correct documentation above. -Matt