From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings Date: Fri, 1 Feb 2013 13:23:51 +0900 Message-ID: <20130201042350.GA6898@verge.net.au> References: <1358955158-1510-1-git-send-email-g.liakhovetski@gmx.de> <1358955158-1510-7-git-send-email-g.liakhovetski@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]:51772 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582Ab3BAEXy (ORCPT ); Thu, 31 Jan 2013 23:23:54 -0500 Content-Disposition: inline In-Reply-To: <1358955158-1510-7-git-send-email-g.liakhovetski@gmx.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Chris Ball On Wed, Jan 23, 2013 at 04:32:33PM +0100, Guennadi Liakhovetski wrote: > Define device-tree bindings for the tmio-mmc driver to be able to specify > parameters, currently provided in platform data. > > Cc: Magnus Damm > Signed-off-by: Guennadi Liakhovetski > --- > > Please, comment on this one, since it is defining an ABI > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > new file mode 100644 > index 0000000..dd8decd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > @@ -0,0 +1,19 @@ > +* Toshiba Mobile IO SD/MMC controller > + > +The tmio-mmc driver doesn't probe its devices actively, instead its binding to > +devices is managed by either MFD drivers or by the sh_mobile_sdhi platform > +driver. Those drivers supply the tmio-mmc driver with platform data, that either > +describe hardware capabilities, known to them, or are obtained by them from > +their own platform data or from their DT information. In the latter case all > +compulsory and any optional properties, common to all SD/MMC drivers, as > +described in mmc.txt, should or can be used. Additionally the following optional > +bindings can be used. They set either respective TMIO_MMC_* flags or MMC_CAP_* > +capabilities. > + > +Optional properties: > +- toshiba,mmc-wrprotect-disable : set TMIO_MMC_WRPROTECT_DISABLE flag > +- toshiba,mmc-blksz-2bytes : set TMIO_MMC_BLKSZ_2BYTES > +- toshiba,mmc-cap-sdio-irq : SDIO IRQ signalling should be used, if > + supported by the hardware, i.e. set MMC_CAP_SDIO_IRQ if > + TMIO_MMC_SDIO_IRQ is also set > +- toshiba,mmc-has-idle-wait : set TMIO_MMC_HAS_IDLE_WAIT FWIW, TMIO_MMC_HAS_IDLE_WAIT appears to be required for SDHI0 to function on the Marzen board. As I have been doing some work on bring up the Marzen board using DT I am very happy to see these new bindings.