From: Anatolij Gustschin <agust@denx.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Javier Martin <javier.martin@vista-silicon.com>,
linux-mmc@vger.kernel.org, viresh.linux@gmail.com,
g.liakhovetski@gmx.de, vinod.koul@linux.intel.com,
s.hauer@pengutronix.de, cjb@laptop.org, gcembed@gmail.com,
festevam@gmail.com
Subject: Re: [PATCH v2] mmc: mxcmmc: fix bug that may block a data transfer forever.
Date: Thu, 14 Mar 2013 20:58:57 +0100 [thread overview]
Message-ID: <20130314205857.7b0ad091@crub> (raw)
In-Reply-To: <5126421D.7010204@freescale.com>
Hi Fabio,
On Thu, 21 Feb 2013 12:49:49 -0300
Fabio Estevam <fabio.estevam@freescale.com> wrote:
> Hi Anatolij,
>
> Anatolij Gustschin wrote:
>
> > this change introduces a race condition for host->req (and maybe
> > for host->data) accesses. The callback is running in soft-irq context and can
> > be interrupted by the mxcmci_irq() interrupt which can finish the request and
> > set host->req to NULL. Then mxcmci_data_done() crashes with a null pointer
> > dereference. How extensively was it tested?
>
> Does the patch below help?
Sorry for long delay. No, it doesn't help. With this patch applied
the task copying data to the sd-card hangs forever. I used following
patch to fix observed crashes:
http://thread.gmane.org/gmane.linux.kernel.mmc/19658/focus=19662
Thanks anyway!
Anatolij
prev parent reply other threads:[~2013-03-14 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 10:43 [PATCH v2] mmc: mxcmmc: fix bug that may block a data transfer forever Javier Martin
2012-09-10 7:47 ` Sascha Hauer
2012-09-19 5:52 ` Chris Ball
2012-09-14 2:52 ` Vinod Koul
2012-09-14 12:50 ` javier Martin
2013-02-19 14:14 ` Anatolij Gustschin
2013-02-21 12:32 ` javier Martin
2013-02-21 12:57 ` Anatolij Gustschin
2013-02-21 15:49 ` Fabio Estevam
2013-03-14 19:58 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314205857.7b0ad091@crub \
--to=agust@denx.de \
--cc=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=gcembed@gmail.com \
--cc=javier.martin@vista-silicon.com \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=vinod.koul@linux.intel.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox