From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] mfd:rtsx: Support RTS5249 Date: Mon, 25 Mar 2013 09:29:00 +0300 Message-ID: <20130325062900.GC9189@mwanda> References: <1364177636-4294-1-git-send-email-wei_wang@realsil.com.cn> <20130325060038.GD9138@mwanda> <514FED71.8020307@realsil.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:50649 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755126Ab3CYG3U (ORCPT ); Mon, 25 Mar 2013 02:29:20 -0400 Content-Disposition: inline In-Reply-To: <514FED71.8020307@realsil.com.cn> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: wwang Cc: cjb@laptop.org, sameo@linux.intel.com, gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, rogerable@realtek.com, devel@linuxdriverproject.org On Mon, Mar 25, 2013 at 02:23:45PM +0800, wwang wrote: > =E4=BA=8E 2013=E5=B9=B403=E6=9C=8825=E6=97=A5 14:00, Dan Carpenter =E5= =86=99=E9=81=93: > >On Mon, Mar 25, 2013 at 10:13:56AM +0800, wei_wang@realsil.com.cn wr= ote: > >>+static int rts5249_optimize_phy(struct rtsx_pcr *pcr) > >>+{ > >>+ int err; > >>+ > >>+ err =3D rtsx_pci_write_phy_register(pcr, 0x19, 0xFE46); > >>+ if (err < 0) > >>+ return err; > >>+ > >>+ mdelay(1); > >Why do we have the mdelay() and the later msleep(5)? > >rtsx_pci_write_phy_register() busy loops until the write succeeds or > >it returns -ETIMEOUT. The extra wait here seems unnecessary. > > > >regards, > >dan carpenter > > > > > >. >=20 > Hi, >=20 > The busy loops in rtsx_pci_write_phy_register only tell us that the > write sequence succeeds. The device still needs to wait for a while > until the internal signal stable. Or else the timing won't fit the > requirement. > All of the delays in the driver are necessary. Ok. Cool. regards, dan carpenter