Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

Chris Ball
2013-03-27T13:31:58Z

Hi Maya, Kevin, Seungwon, Jaehoon,

On Fri, Mar 01 2013, Ulf Hansson wrote:
> From: Ulf Hansson <ulf.hansson@linaro.org>
>
> SDIO has been using runtime pm for a while to handle runtime power save
> operations. This patchset is enabling the option to make the sd/mmc
> blockdevices to use runtime pm as well.
>
> The runtime pm implementation for the block device will make use of
> autosuspend to defer power save operation to after request inactivty for
> a certain time.
>
> To actually perform some power save operations the corresponding bus ops
> for mmc and sd shall be implemented. Typically it could make sense to do
> BKOPS for eMMC in here.
>
> Ulf Hansson (3):
> mmc: core: Remove power_restore bus_ops for mmc and sd
> mmc: core: Add bus_ops for runtime pm callbacks
> mmc: block: Enable runtime pm for mmc blkdevice
>
> drivers/mmc/card/block.c | 28 ++++++++++++++++++++++++++--
> drivers/mmc/core/bus.c | 14 ++++++++++++--
> drivers/mmc/core/core.h | 2 ++
> drivers/mmc/core/mmc.c | 14 --------------
> drivers/mmc/core/sd.c | 14 --------------
> drivers/mmc/core/sdio.c | 20 ++++++++++++++++++++
> 6 files changed, 60 insertions(+), 32 deletions(-)

This looks good to me, but I'd like to make sure the design works for
you before we decide to merge it. Any concerns?

Thanks,

- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child