Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

Ulf Hansson
2013-04-02T10:45:22Z

On 28 March 2013 22:05, <merez@codeaurora.org> wrote:
> Hi Chris,
>
> Sorry for the late response.
> I am currently on vacation and would get back to work next week.
> We would like to have an internal discussion to make sure there are no
> additional concerns with this patch.
> Can you please wait with this patch approval until the end of next week?

Hi Maya,

Hope you have had a good vacation. I was thinking of the BKOPS patches
I assume you are working on. If you need some assistance to "rebase"
you work on top of this patchset, just ping me.

Kind regards
Ulf Hansson

>
> Thanks,
> Maya
>
>>> -----Original Message-----
>>> From: Chris Ball [mailto:cjb@laptop.org]
>>> Sent: Wednesday, March 27, 2013 9:32 PM
>>> To: Ulf Hansson
>>> Cc: linux-mmc@vger.kernel.org; Johan Rudholm; Ulf Hansson; Maya Erez;
>>> Kevin Liu; Seungwon Jeon; jh80.chung@samsung.com
>>> Subject: Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice
>>>
>>> Hi Maya, Kevin, Seungwon, Jaehoon,
>>>
>>> On Fri, Mar 01 2013, Ulf Hansson wrote:
>>>> From: Ulf Hansson <ulf.hansson@linaro.org>
>>>>
>>>> SDIO has been using runtime pm for a while to handle runtime power save
>>>> operations. This patchset is enabling the option to make the sd/mmc
>>>> blockdevices to use runtime pm as well.
>>>>
>>>> The runtime pm implementation for the block device will make use of
>>>> autosuspend to defer power save operation to after request inactivty
>>>> for
>>>> a certain time.
>>>>
>>>> To actually perform some power save operations the corresponding bus
>>>> ops
>>>> for mmc and sd shall be implemented. Typically it could make sense to
>>>> do
>>>> BKOPS for eMMC in here.
>>>>
>>>> Ulf Hansson (3):
>>>> mmc: core: Remove power_restore bus_ops for mmc and sd
>>>> mmc: core: Add bus_ops for runtime pm callbacks
>>>> mmc: block: Enable runtime pm for mmc blkdevice
>>>>
>>>> drivers/mmc/card/block.c | 28 ++++++++++++++++++++++++++--
>>>> drivers/mmc/core/bus.c | 14 ++++++++++++--
>>>> drivers/mmc/core/core.h | 2 ++
>>>> drivers/mmc/core/mmc.c | 14 --------------
>>>> drivers/mmc/core/sd.c | 14 --------------
>>>> drivers/mmc/core/sdio.c | 20 ++++++++++++++++++++
>>>> 6 files changed, 60 insertions(+), 32 deletions(-)
>>>
>>> This looks good to me, but I'd like to make sure the design works for
>>> you before we decide to merge it. Any concerns?
>>>
>>
>> Chris,
>>
>> This patchset is ok for me.
>> We can discuss/review how sd/mmc runtime callback function implemented
>> later.
>>
>> Thanks
>> Kevin
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
> --
> Maya Erez
> QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>