From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH] mmc: mxs-mmc: Add broken-cd devicetree property Date: Sat, 6 Apr 2013 17:06:54 +0200 Message-ID: <201304061706.54320.marex@denx.de> References: <1365255828-6416-1-git-send-email-aletes.xgr@gmail.com> <51602A0B.6020405@pengutronix.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Pereira da Silva Cc: Marc Kleine-Budde , Chris Ball , Shawn Guo , fabio.estevam@freescale.com, Otavio Salvador , Mark Brown , linux-mmc@vger.kernel.org, LKML List-Id: linux-mmc@vger.kernel.org Dear Alexandre Pereira da Silva, > On Sat, Apr 6, 2013 at 10:58 AM, Marc Kleine-Budde wrote: > > According to the documentation broken card detect is something different > > > > than non-removable: > > > - broken-cd: There is no card detection available; polling must be > > > used. - non-removable: non-removable slot (like eMMC); assume always > > > present. > > > > But mxs-mmc set MMC_CAP_NEEDS_POLL unconditionally. > > I will work on a better way to fix this. NEEDS_POLL looks nice and seems to fit this case. Best regards, Marek Vasut