From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT Date: Thu, 18 Apr 2013 09:02:38 +0100 Message-ID: <20130418080238.GB3137@gmail.com> References: <1366205534-25079-1-git-send-email-lee.jones@linaro.org> <201304171550.56037.arnd@arndb.de> <20130417150437.GA3137@gmail.com> <201304171731.56292.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-we0-f182.google.com ([74.125.82.182]:34758 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965925Ab3DRICn (ORCPT ); Thu, 18 Apr 2013 04:02:43 -0400 Received: by mail-we0-f182.google.com with SMTP id m1so1978586wea.13 for ; Thu, 18 Apr 2013 01:02:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <201304171731.56292.arnd@arndb.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linus.walleij@stericsson.com, Russell King , Chris Ball , linux-mmc@vger.kernel.org > I think you can further simplify this, given that in the DT case we a= lways > allocate a zeroed mmci_platform_data for host->plat, so !plat cannot = happen > when we get here. Okay, third time lucky. :) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 372e921..3260ab4 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -298,14 +298,16 @@ static void mmci_init_sg(struct mmci_host *host, = struct mmc_data *data) * no custom DMA interfaces are supported. */ #ifdef CONFIG_DMA_ENGINE -static void mmci_dma_setup(struct mmci_host *host) +static void mmci_dma_setup(struct amba_device *dev, + struct mmci_host *host) { + struct device_node *np =3D dev->dev.of_node; struct mmci_platform_data *plat =3D host->plat; const char *rxname, *txname; dma_cap_mask_t mask; =20 - if (!plat || !plat->dma_filter) { - dev_info(mmc_dev(host->mmc), "no DMA platform data\n"); + if (!(plat->dma_filter || np)) { + dev_info(mmc_dev(host->mmc), "no DMA platform data or DT\n"); return; } =20 @@ -321,19 +323,21 @@ static void mmci_dma_setup(struct mmci_host *host= ) * attempt to use it bidirectionally, however if it is * is specified but cannot be located, DMA will be disabled. */ - if (plat->dma_rx_param) { - host->dma_rx_channel =3D dma_request_channel(mask, - plat->dma_filter, - plat->dma_rx_param); + if (plat->dma_rx_param || np) { + host->dma_rx_channel =3D dma_request_slave_channel_compat(mask, + plat->dma_filter, + plat->dma_rx_param, + &dev->dev, "rx"); /* E.g if no DMA hardware is present */ if (!host->dma_rx_channel) dev_err(mmc_dev(host->mmc), "no RX DMA channel\n"); } =20 - if (plat->dma_tx_param) { - host->dma_tx_channel =3D dma_request_channel(mask, - plat->dma_filter, - plat->dma_tx_param); + if (plat->dma_tx_param || np) { + host->dma_tx_channel =3D dma_request_slave_channel_compat(mask, + plat->dma_filter, + plat->dma_tx_param, + &dev->dev, "tx"); if (!host->dma_tx_channel) dev_warn(mmc_dev(host->mmc), "no TX DMA channel\n"); } else { @@ -1538,7 +1542,7 @@ static int mmci_probe(struct amba_device *dev, amba_rev(dev), (unsigned long long)dev->res.start, dev->irq[0], dev->irq[1]); =20 - mmci_dma_setup(host); + mmci_dma_setup(dev, host); =20 pm_runtime_set_autosuspend_delay(&dev->dev, 50); pm_runtime_use_autosuspend(&dev->dev); --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog