From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Doug Anderson <dianders@chromium.org>
Cc: "Thomas Abraham" <thomas.abraham@linaro.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Patch Tracking" <patches@linaro.org>,
"Seungwon Jeon" <tgih.jun@samsung.com>,
"Tomasz Figa" <t.figa@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Girish Shivananjappa" <girish.shivananjappa@linaro.org>,
"Chris Ball" <cjb@laptop.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration
Date: Fri, 19 Apr 2013 11:11:31 +0100 [thread overview]
Message-ID: <20130419101131.GH14496@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAD=FV=UddWM=yc5N9=jwbMDpZ7Bpg7o3Z714CnBSg=iHhmPxWw@mail.gmail.com>
On Wed, Apr 10, 2013 at 06:56:48AM -0700, Doug Anderson wrote:
> Thomas,
>
> On Wed, Apr 10, 2013 at 5:48 AM, Thomas Abraham
> <thomas.abraham@linaro.org> wrote:
> > The call to regulator_enable() is prior to the call to mmc_add_host().
> > Hence, call to mmc_fre_host is not required in this case. So the above
> > change should be right.
>
> Are you sure that mmc_free_host() is the opposite of mmc_add_host()
> and not mmc_alloc_host()?
mmc_free_host() undoes mmc_alloc_host(). mmc_remove_host() undoes
mmc_add_host().
alloc
add
remove
free
is pretty standard terminology, standard ordering. If add fails, then
free is the right thing to call to clean up after the alloc.
prev parent reply other threads:[~2013-04-19 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 5:59 [PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration Thomas Abraham
2013-04-09 23:30 ` Doug Anderson
2013-04-10 12:48 ` Thomas Abraham
2013-04-10 13:56 ` Doug Anderson
2013-04-10 14:55 ` Doug Anderson
2013-04-11 3:13 ` Seungwon Jeon
2013-04-11 12:06 ` Thomas Abraham
2013-04-19 10:11 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419101131.GH14496@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=girish.shivananjappa@linaro.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=t.figa@samsung.com \
--cc=tgih.jun@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox