From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration Date: Fri, 19 Apr 2013 11:11:31 +0100 Message-ID: <20130419101131.GH14496@n2100.arm.linux.org.uk> References: <1365487186-4587-1-git-send-email-thomas.abraham@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Doug Anderson Cc: Thomas Abraham , linux-samsung-soc , Heiko =?iso-8859-1?Q?St=FCbner?= , Patch Tracking , Seungwon Jeon , Tomasz Figa , "linux-mmc@vger.kernel.org" , Jaehoon Chung , Kukjin Kim , Girish Shivananjappa , Chris Ball , Linus Walleij , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org On Wed, Apr 10, 2013 at 06:56:48AM -0700, Doug Anderson wrote: > Thomas, > > On Wed, Apr 10, 2013 at 5:48 AM, Thomas Abraham > wrote: > > The call to regulator_enable() is prior to the call to mmc_add_host(). > > Hence, call to mmc_fre_host is not required in this case. So the above > > change should be right. > > Are you sure that mmc_free_host() is the opposite of mmc_add_host() > and not mmc_alloc_host()? mmc_free_host() undoes mmc_alloc_host(). mmc_remove_host() undoes mmc_add_host(). alloc add remove free is pretty standard terminology, standard ordering. If add fails, then free is the right thing to call to clean up after the alloc.