From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Baatz Subject: Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines Date: Tue, 23 Apr 2013 23:22:25 +0200 Message-ID: <20130423212224.GA29507@schnuecks.de> References: <1366660500-26835-1-git-send-email-gmbnomis@gmail.com> <1366660500-26835-2-git-send-email-gmbnomis@gmail.com> <87wqrutjss.fsf@octavius.laptop.org> <20130422203723.GI29947@lunn.ch> <20130422210949.GJ25724@titan.lakedaemon.net> <20130422214543.GJ29947@lunn.ch> <87sj2iteue.fsf@octavius.laptop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-bk0-f42.google.com ([209.85.214.42]:61593 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652Ab3DWVW2 (ORCPT ); Tue, 23 Apr 2013 17:22:28 -0400 Received: by mail-bk0-f42.google.com with SMTP id jc3so470257bkc.15 for ; Tue, 23 Apr 2013 14:22:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87sj2iteue.fsf@octavius.laptop.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball , Guennadi Liakhovetski Cc: Andrew Lunn , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, thomas.petazzoni@free-electrons.com Hi Chris, Guennadi, On Mon, Apr 22, 2013 at 05:50:17PM -0400, Chris Ball wrote: > Hi, > > On Mon, Apr 22 2013, Andrew Lunn wrote: > >> Nothing else really jumps out though. Where either of these what you > >> were thinking of? > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/138514.html > > > > and > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/138513.html > > These patches move mvsdio to slot-gpio, which is a prerequisite for > using the shared mmc_of_parse(), but they don't go all the way to > using mmc_of_parse(). That's nice functionality, I was not aware of that. I will convert this to mmc_of_parse() once I find some time. One question already: Why does mmc_of_parse() not return errors to the caller? If, for example, a GPIO line was given for CD in the DT, but it could not be obtained, shouldn't the caller at least have the possibility to handle this as an error? (mvsdio currently aborts the probe if it can't get the GPIO line). - Simon