From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?iso-8859-1?q?St=FCbner?= Subject: Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs Date: Wed, 5 Jun 2013 20:50:00 +0200 Message-ID: <201306052050.00410.heiko@sntech.de> References: <201306030055.15413.heiko@sntech.de> <51AF72F9.3060307@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <51AF72F9.3060307-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Stephen Warren Cc: Laurent Pinchart , Mike Turquette , Seungwon Jeon , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Jaehoon Chung , John Stultz , Grant Likely , Russell King , Thomas Gleixner , Chris Ball , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-mmc@vger.kernel.org Am Mittwoch, 5. Juni 2013, 19:18:49 schrieb Stephen Warren: > On 06/05/2013 01:01 AM, Linus Walleij wrote: > > On Tue, Jun 4, 2013 at 2:05 PM, Heiko St=FCbner wrote: > ... > = > >> The only problem is the pull stuff mentioned above that is either pull > >> up or down without the driver having knowledge about it. And > >> generic_pinconf only knows about them separately right now. > > = > > Create a separate patch adding PIN_CONFIG_BIAS_PULL_AUTO > > to include/linux/pinctrl/pinconf-generic.h, don't forget the > > kerneldoc, and patching drivers/pinctrl/pinconf-generic.c. > = > "AUTO" sounds really rather generic. Based on just the word "AUTO", I > have no idea if it's a HW- or SW-supplied default, or what the algorithm > is for determining the automatically selected value. Perhaps > s/AUTO/PIN_DEFAULT/ or something like that? I would also go with PIN_DEFAULT, which somehow captures what the function = does better than "AUTO". So, if no-one objects I'll go with Stephen's = suggestion. > While the concept is simple enough, it's unusual enough that such a > patch would hopefully have a comment containing a full explanation of > exactly what this option means. of course :-)