From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH] dmaengine: shdma: fix a build failure on platforms with no DMA support Date: Wed, 10 Jul 2013 11:09:47 +0900 Message-ID: <20130710020947.GP32603@verge.net.au> References: <51A77CF1.7040105@ti.com> <20130531024438.GB32564@verge.net.au> <20130705045350.GA10947@intel.com> <20130708072114.GF16653@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]:34956 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627Ab3GJCJu (ORCPT ); Tue, 9 Jul 2013 22:09:50 -0400 Content-Disposition: inline In-Reply-To: <20130708072114.GF16653@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Vinod Koul Cc: Olof Johansson , Guennadi Liakhovetski , Kevin Hilman , Dan Murphy , "linux-mmc@vger.kernel.org" , Linux-sh list , Chris Ball , linux-arm-kernel On Mon, Jul 08, 2013 at 12:51:14PM +0530, Vinod Koul wrote: > On Mon, Jul 08, 2013 at 12:52:16AM -0700, Olof Johansson wrote: > > On Thu, Jul 4, 2013 at 9:53 PM, Vinod Koul wrote: > > > On Wed, Jun 19, 2013 at 09:32:18PM +0200, Guennadi Liakhovetski wrote: > > >> Hi Vinod > > >> > > >> On Wed, 19 Jun 2013, Kevin Hilman wrote: > > >> > > >> > On Thu, May 30, 2013 at 7:44 PM, Simon Horman wrote: > > >> > > > >> > [...] > > >> > > > >> > > thanks for this. I will wait for a refresh (as we discussed earlier today). > > >> > > Can I confirm that this is a fix for v3.10? If so, could ou note > > >> > > that when you post your revised patch? > > >> > > > >> > Any progress on this patch? > > >> > > > >> > The SH-mobile defconfigs are still all failing in linux-next. > > >> > > >> In > > >> > > >> https://patchwork.kernel.org/patch/2640061/ > > > And you havent CC maintainers on this patch, so I dont have it! > > >> > > >> I proposed a simple immediate fix for this problem. Arnd at the same time > > >> developed an alternative solution: > > >> > > >> https://patchwork.kernel.org/patch/2644121/ > > >> https://patchwork.kernel.org/patch/2644111/ > > > Reading these patches I agree with Arnd that client drivers should not depend on > > > dma slave drivers. Existing issue need to be fixed > > > > > > Arnd, Have you merged these changes? > > > > Looks like we now have breakage in linux-next for this again (new > > breakage due to the header file move being applied by you on Friday, > > Vinod? Are you planning on sending the code in for 3.11? If not, you > > shouldn't apply patches right now). > Well they were already in my tree since 18th June. (tree was rebased to fixup for > pull on friday) and now these are in Linus's tree. > > Can we have a fix for breakage for now sent to linus for now and then address the > proper way to do this? That is my preferred approach. I will repost the patch at the link https://patchwork.kernel.org/patch/2640061/ above, rebased for the header file rename. Vinod, can you take things from there?