From: Olof Johansson <olof@lixom.net>
To: Simon Horman <horms@verge.net.au>
Cc: Vinod Koul <vinod.koul@intel.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Kevin Hilman <khilman@linaro.org>, Dan Murphy <dmurphy@ti.com>,
linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Chris Ball <cjb@laptop.org>,
Magnus Damm <magnusdamm@gmail.com>
Subject: Re: [PATCH] dmaengine: shdma: fix a build failure on platforms with no DMA support
Date: Mon, 22 Jul 2013 19:39:07 -0700 [thread overview]
Message-ID: <20130723023907.GC14983@quad.lixom.net> (raw)
In-Reply-To: <20130716012041.GA942@verge.net.au>
On Tue, Jul 16, 2013 at 10:20:41AM +0900, Simon Horman wrote:
> On Wed, Jul 10, 2013 at 11:09:12AM +0900, Simon Horman wrote:
> > From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >
> > On platforms with no support for the shdma dmaengine driver build is
> > currently failing with
> >
> > drivers/built-in.o: In function `sh_mobile_sdhi_probe':
> > drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to`shdma_chan_filter'
> >
> > Fix the breakage by defining shdma_chan_filter to NULL in such
> > configurations.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > [horms+renesas@verge.net.au: Apply change to shdma-base.h instead of sh_dma.h]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > include/linux/shdma-base.h | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> >
> > Hi Vinod,
> >
> > please consider this fix from Guennadi for v3.11 which I have rebased on top of
> > next-20130709. It fixes a build problem on a number of shmobile defconfigs
> > including bockw.
>
> Ping.
>
> Would it be appropriate for me to take this change through my tree?
> It seems to resolve a regression in v3.11-rc1.
I'll take it through arm-soc since there's no response from Vinod. I've
applied it in the fixes branch we have.
-Olof
next prev parent reply other threads:[~2013-07-23 2:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 2:09 [PATCH] dmaengine: shdma: fix a build failure on platforms with no DMA support Simon Horman
2013-07-16 1:20 ` Simon Horman
2013-07-23 2:39 ` Olof Johansson [this message]
2013-07-23 4:12 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-05-30 16:02 Guennadi Liakhovetski
2013-05-30 16:23 ` Dan Murphy
2013-05-31 2:44 ` Simon Horman
2013-06-19 19:00 ` Kevin Hilman
2013-06-19 19:32 ` Guennadi Liakhovetski
2013-07-05 4:53 ` Vinod Koul
2013-07-08 7:52 ` Olof Johansson
2013-07-08 7:21 ` Vinod Koul
2013-07-10 2:09 ` Simon Horman
2013-07-08 8:13 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723023907.GC14983@quad.lixom.net \
--to=olof@lixom.net \
--cc=cjb@laptop.org \
--cc=dmurphy@ti.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnusdamm@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox