Re: [patch] mmc: sdhci-bcm-kona: '|' vs '&' typo

Dan Carpenter
2013-08-21T09:14:26Z

On Wed, Aug 21, 2013 at 10:57:57AM +0200, walter harms wrote:
>
>
> Am 21.08.2013 10:24, schrieb Dan Carpenter:
> > The intent was to test if a flag was set. In the current code the
> > conditions are always true.
>
> I guess that it worked before ...
> That leaves the Question: are the tests needed at all ?

It's flagging everything as broken, and I presume that isn't good.
But on the other hand, these changes do occasionally break things
because now a lot of new untested code is used. It really is a good
idea for someone to test this.

> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static checker stuff. Untested.

regards,
dan carpenter