From: Shawn Guo <shawn.guo@linaro.org>
To: Dong Aisheng <b29396@freescale.com>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, anton@enomsg.org,
linux-arm-kernel@lists.infradead.org, s.hauer@pengutronix.de
Subject: Re: [PATCH 5/8] sdhci: sdhci-esdhc-imx: change pinctrl state according to uhs mode
Date: Thu, 5 Sep 2013 14:34:02 +0800 [thread overview]
Message-ID: <20130905063345.GD775@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <1378299257-2980-6-git-send-email-b29396@freescale.com>
On Wed, Sep 04, 2013 at 08:54:14PM +0800, Dong Aisheng wrote:
> Without proper pinctrl state, the card may not be able to work
> on high speed stablely. e.g. SDR104.
>
> This patch add pinctrl state switch code according to different
> uhs mode include 100mhz sate, 200mhz sate and normal state
> (50Mhz and below).
>
> Signed-off-by: Dong Aisheng <b29396@freescale.com>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 110 ++++++++++++++++++++++++++-
> include/linux/platform_data/mmc-esdhc-imx.h | 4 +
> 2 files changed, 113 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 36b9f63..3e89863 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -49,6 +49,10 @@
>
> #define ESDHC_TUNING_BLOCK_PATTERN_LEN 64
>
> +/* pinctrl state */
> +#define ESDHC_PINCTRL_STATE_100MHZ "state_100mhz"
> +#define ESDHC_PINCTRL_STATE_200MHZ "state_200mhz"
> +
> /*
> * Our interpretation of the SDHCI_HOST_CONTROL register
> */
> @@ -90,6 +94,10 @@ struct pltfm_imx_data {
> u32 scratchpad;
> enum imx_esdhc_type devtype;
> struct pinctrl *pinctrl;
> + struct pinctrl_state *pins_current;
> + struct pinctrl_state *pins_default;
> + struct pinctrl_state *pins_100mhz;
> + struct pinctrl_state *pins_200mhz;
> struct esdhc_platform_data boarddata;
> struct clk *clk_ipg;
> struct clk *clk_ahb;
> @@ -642,6 +650,75 @@ static int esdhc_executing_tuning(struct sdhci_host *host, u32 opcode)
> return ret;
> }
>
> +static int esdhc_change_pinstate(struct sdhci_host *host,
> + unsigned int uhs)
> +{
> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> + struct pltfm_imx_data *imx_data = pltfm_host->priv;
> + struct pinctrl_state *pinctrl;
> + int ret;
> +
> + dev_dbg(mmc_dev(host->mmc), "change pinctrl state for uhs %d\n", uhs);
> +
> + if (IS_ERR(imx_data->pinctrl) ||
> + IS_ERR(imx_data->pins_default) ||
> + IS_ERR(imx_data->pins_100mhz) ||
> + IS_ERR(imx_data->pins_200mhz))
> + return -EINVAL;
> +
> + switch (uhs) {
> + case MMC_TIMING_UHS_SDR12:
> + case MMC_TIMING_UHS_SDR25:
> + case MMC_TIMING_UHS_DDR50:
> + pinctrl = imx_data->pins_default;
> + break;
> + case MMC_TIMING_UHS_SDR50:
> + pinctrl = imx_data->pins_100mhz;
> + break;
> + case MMC_TIMING_UHS_SDR104:
> + pinctrl = imx_data->pins_200mhz;
> + break;
> + default:
> + /* back to default state for other legacy timing */
> + pinctrl = imx_data->pins_default;
> + }
So it can be equally written as below?
switch (uhs) {
case MMC_TIMING_UHS_SDR104:
pinctrl = imx_data->pins_200mhz;
break;
case MMC_TIMING_UHS_SDR50:
pinctrl = imx_data->pins_100mhz;
break;
default:
pinctrl = imx_data->pins_default;
}
> +
> + if (pinctrl == imx_data->pins_current)
> + return 0;
I think pinctrl_select_state() already take care of the check?
> +
> + ret = pinctrl_select_state(imx_data->pinctrl, pinctrl);
> + if (!ret)
> + imx_data->pins_current = pinctrl;
> +
> + return ret;
> +}
> +
> +static int esdhc_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs)
> +{
> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> + struct pltfm_imx_data *imx_data = pltfm_host->priv;
> +
> + switch (uhs) {
> + case MMC_TIMING_UHS_SDR12:
> + imx_data->uhs_mode = SDHCI_CTRL_UHS_SDR12;
> + break;
> + case MMC_TIMING_UHS_SDR25:
> + imx_data->uhs_mode = SDHCI_CTRL_UHS_SDR25;
> + break;
> + case MMC_TIMING_UHS_SDR50:
> + imx_data->uhs_mode = SDHCI_CTRL_UHS_SDR50;
> + break;
> + case MMC_TIMING_UHS_SDR104:
> + imx_data->uhs_mode = SDHCI_CTRL_UHS_SDR104;
> + break;
> + case MMC_TIMING_UHS_DDR50:
> + imx_data->uhs_mode = SDHCI_CTRL_UHS_DDR50;
> + break;
> + }
> +
> + return esdhc_change_pinstate(host, uhs);
> +}
> +
> static const struct sdhci_ops sdhci_esdhc_ops = {
> .read_l = esdhc_readl_le,
> .read_w = esdhc_readw_le,
> @@ -653,6 +730,7 @@ static const struct sdhci_ops sdhci_esdhc_ops = {
> .get_min_clock = esdhc_pltfm_get_min_clock,
> .get_ro = esdhc_pltfm_get_ro,
> .platform_bus_width = esdhc_pltfm_bus_width,
> + .set_uhs_signaling = esdhc_set_uhs_signaling,
> .platform_execute_tuning = esdhc_executing_tuning,
> };
>
> @@ -695,6 +773,11 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev,
>
> of_property_read_u32(np, "max-frequency", &boarddata->f_max);
>
> + if (of_find_property(np, "no-1-8-v", NULL))
> + boarddata->support_vsel = false;
> + else
> + boarddata->support_vsel = true;
So you check "no-1-8-v" property, set support_vsel here and then set
SDHCI_QUIRK2_NO_1_8_V accordingly below in sdhci_esdhc_imx_probe().
But sdhci_get_of_property() - sdhci-pltfm.c already does the job.
Shawn
> +
> return 0;
> }
> #else
> @@ -757,12 +840,20 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
> clk_prepare_enable(imx_data->clk_ipg);
> clk_prepare_enable(imx_data->clk_ahb);
>
> - imx_data->pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + imx_data->pinctrl = devm_pinctrl_get(&pdev->dev);
> if (IS_ERR(imx_data->pinctrl)) {
> err = PTR_ERR(imx_data->pinctrl);
> goto disable_clk;
> }
>
> + imx_data->pins_default = pinctrl_lookup_state(imx_data->pinctrl,
> + PINCTRL_STATE_DEFAULT);
> + if (IS_ERR(imx_data->pins_default)) {
> + err = PTR_ERR(imx_data->pins_default);
> + dev_err(mmc_dev(host->mmc), "could not get default state\n");
> + goto disable_clk;
> + }
> +
> host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>
> if (is_imx25_esdhc(imx_data) || is_imx35_esdhc(imx_data))
> @@ -839,6 +930,23 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
> break;
> }
>
> + /* sdr50 and sdr104 needs work on 1.8v signal voltage */
> + if ((boarddata->support_vsel) && is_imx6q_usdhc(imx_data)) {
> + imx_data->pins_100mhz = pinctrl_lookup_state(imx_data->pinctrl,
> + ESDHC_PINCTRL_STATE_100MHZ);
> + imx_data->pins_200mhz = pinctrl_lookup_state(imx_data->pinctrl,
> + ESDHC_PINCTRL_STATE_200MHZ);
> + if (IS_ERR(imx_data->pins_100mhz) ||
> + IS_ERR(imx_data->pins_200mhz)) {
> + dev_warn(mmc_dev(host->mmc),
> + "could not get ultra high speed state, work on normal mode\n");
> + /* fall back to not support uhs by specify no 1.8v quirk */
> + host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
> + }
> + } else {
> + host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
> + }
> +
> err = sdhci_add_host(host);
> if (err)
> goto disable_clk;
> diff --git a/include/linux/platform_data/mmc-esdhc-imx.h b/include/linux/platform_data/mmc-esdhc-imx.h
> index d44912d..a0f5a8f 100644
> --- a/include/linux/platform_data/mmc-esdhc-imx.h
> +++ b/include/linux/platform_data/mmc-esdhc-imx.h
> @@ -10,6 +10,8 @@
> #ifndef __ASM_ARCH_IMX_ESDHC_H
> #define __ASM_ARCH_IMX_ESDHC_H
>
> +#include <linux/types.h>
> +
> enum wp_types {
> ESDHC_WP_NONE, /* no WP, neither controller nor gpio */
> ESDHC_WP_CONTROLLER, /* mmc controller internal WP */
> @@ -32,6 +34,7 @@ enum cd_types {
> * @cd_gpio: gpio for card_detect interrupt
> * @wp_type: type of write_protect method (see wp_types enum above)
> * @cd_type: type of card_detect method (see cd_types enum above)
> + * @support_vsel: indicate it supports 1.8v switching
> */
>
> struct esdhc_platform_data {
> @@ -41,5 +44,6 @@ struct esdhc_platform_data {
> enum cd_types cd_type;
> int max_bus_width;
> unsigned int f_max;
> + bool support_vsel;
> };
> #endif /* __ASM_ARCH_IMX_ESDHC_H */
> --
> 1.7.1
>
>
next prev parent reply other threads:[~2013-09-05 6:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 12:54 [PATCH 0/8] mmc: sdhci-esdhc-imx: add SD3.0 support Dong Aisheng
2013-09-04 12:54 ` [PATCH 1/8] mmc: sdhci: add hooks for platform specific tuning Dong Aisheng
2013-09-05 3:14 ` Shawn Guo
2013-09-05 14:53 ` Dong Aisheng
2013-09-04 12:54 ` [PATCH 2/8] mmc: sdhci: allow platform access of sdhci_send_command Dong Aisheng
2013-09-04 12:54 ` [PATCH 3/8] sdhci: sdhci-esdhc-imx: support real clock on and off for imx6q Dong Aisheng
2013-09-05 4:32 ` Shawn Guo
2013-09-05 14:59 ` Dong Aisheng
2013-09-04 12:54 ` [PATCH 4/8] sdhci: sdhci-esdhci-imx: add sd3.0 clock tuning support Dong Aisheng
2013-09-05 6:00 ` Shawn Guo
2013-09-05 15:02 ` Dong Aisheng
2013-09-05 7:33 ` Ulf Hansson
2013-09-05 17:52 ` Dong Aisheng
2013-09-16 7:48 ` Ulf Hansson
2013-09-04 12:54 ` [PATCH 5/8] sdhci: sdhci-esdhc-imx: change pinctrl state according to uhs mode Dong Aisheng
2013-09-05 6:34 ` Shawn Guo [this message]
2013-09-05 15:06 ` Dong Aisheng
2013-09-05 7:38 ` Ulf Hansson
2013-09-05 16:04 ` Dong Aisheng
2013-09-13 14:01 ` Ulf Hansson
2013-09-13 16:38 ` Dong Aisheng
2013-09-05 18:40 ` Matt Sealey
2013-09-11 9:26 ` Dong Aisheng
2013-09-27 0:28 ` Matt Sealey
2013-09-04 12:54 ` [PATCH 6/8] mmc: sdhci-esdhc: correct pre_div for imx6q Dong Aisheng
2013-09-04 12:54 ` [PATCH 7/8] mmc: sdhci-esdhc: set actual_clock in clock setting Dong Aisheng
2013-09-04 12:54 ` [PATCH 8/8] ARM: dts: imx6qdl: add uhs pinctrl state for usdhc3 Dong Aisheng
2013-09-05 6:43 ` Shawn Guo
2013-09-05 15:09 ` Dong Aisheng
2013-09-05 8:03 ` Sascha Hauer
2013-09-05 15:29 ` Dong Aisheng
2013-09-05 7:42 ` [PATCH 0/8] mmc: sdhci-esdhc-imx: add SD3.0 support Ulf Hansson
2013-09-05 18:01 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905063345.GD775@shlinux1.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=anton@enomsg.org \
--cc=b29396@freescale.com \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).